Add schemas for form-based elicitation#1020
Merged
Merged
Conversation
Kehrlann
added
enhancement
Kehrlann
force-pushed
the
dgarnier/enum-schema-elicitation
branch
from
f4ef858 to
6ed6c76
Compare
chemicL
requested changes
Jun 11, 2026
chemicL
left a comment
chemicL
left a comment
Member
There was a problem hiding this comment.
Thanks! I left a few comments - they apply to all occurrences of a given pattern in the new code, I didn't repeat it in all the new types.
| * @param defaultValue Optional default value | ||
| * @deprecated Use {@link TitledSingleSelectEnumSchema} instead | ||
| */ | ||
| @Deprecated |
Member
There was a problem hiding this comment.
Does it make sense a new API that is deprecated on day 1?
Contributor
Author
There was a problem hiding this comment.
I think so, if we plan to introduce it.
Spring Boot did this for Jackson 2 support.
Otherwise, we could just skip this altogether since users can do Map<String, Object>
| } | ||
|
|
||
| public Builder enumValue(String enumValue) { | ||
| if (this.enumValues == null) { |
Member
There was a problem hiding this comment.
I noticed we don't check whether enumValue itself is null. Should we?
Closes #691 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
…tation Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/enum-schema-elicitation
branch
from
fb70217 to
9dbdc0d
Compare
Kehrlann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds builder classes to all new enum schema types introduced for form-based elicitation (SEP-1330)
ConformanceServlet is updated to use the new builders and serves as a reference.
Closes #691