Skip to content

fix(ci): changesets publish args#2305

Closed
tk-o wants to merge 2 commits into
mainfrom
fix/changesets-publish-args
Closed

fix(ci): changesets publish args#2305
tk-o wants to merge 2 commits into
mainfrom
fix/changesets-publish-args

Conversation

@tk-o

@tk-o tk-o commented Jun 16, 2026

Copy link
Copy Markdown
Member

This is a follow up PR to #2304 addressing one last CI run issue where changeset publish command was used with an invalid --snapshot argument.

@tk-o tk-o requested a review from a team as a code owner June 16, 2026 18:34
Copilot AI review requested due to automatic review settings June 16, 2026 18:34
@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7421c80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@tk-o, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 52 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4f4eea47-17da-4acb-828e-255bd5d6cd6c

📥 Commits

Reviewing files that changed from the base of the PR and between 15a8edf and 7421c80.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .github/workflows/release_preview.yml
  • pnpm-workspace.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/changesets-publish-args

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tk-o tk-o closed this Jun 16, 2026
@tk-o tk-o deleted the fix/changesets-publish-args branch June 16, 2026 18:35
@tk-o tk-o restored the fix/changesets-publish-args branch June 16, 2026 18:35
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a CI issue in the preview release workflow by removing the invalid --snapshot flag from the changeset publish command. The --snapshot option is only valid for changeset version, which already uses it correctly on the preceding step; passing it to publish caused the CI run to fail.

  • Removes --snapshot from pnpm changeset publish in .github/workflows/release_preview.yml, leaving the correct --no-git-tag --tag <dist-tag> arguments.
  • Bumps the astro catalog version from ^6.3.3 to ^6.4.7 in pnpm-workspace.yaml, with the corresponding lockfile update picking up minor internal helper and markdown-remark upgrades.

Confidence Score: 5/5

Safe to merge — the workflow fix is correct and the astro bump is a straightforward minor-version update backed by a consistent lockfile.

The single-line removal of --snapshot from changeset publish directly addresses the broken CI step, and the rest of the workflow (versioning with --snapshot, publishing with --tag) remains logically intact. The astro catalog bump is a minor upgrade with no apparent breakage risk.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release_preview.yml Removes the invalid --snapshot flag from changeset publish; the fix is correct and the surrounding workflow logic (version with --snapshot, then publish with --tag) is sound.
pnpm-workspace.yaml Bumps the astro catalog pin from ^6.3.3 to ^6.4.7; a routine minor-version update unrelated to the stated CI fix but safe and self-consistent with the lockfile.
pnpm-lock.yaml Lockfile automatically regenerated to reflect the astro 6.4.7 bump and its transitive dependency changes (@astrojs/internal-helpers 0.10.0, @astrojs/markdown-remark 7.2.0).

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant GHA as GitHub Actions
    participant CS as Changesets CLI
    participant NPM as npm Registry

    Note over GHA,NPM: Preview Release Workflow

    GHA->>CS: pnpm changeset version --snapshot snapshot-tag
    CS-->>GHA: Packages versioned with snapshot suffix

    GHA->>CS: pnpm changeset publish --no-git-tag --tag dist-tag
    Note over CS: Fixed - snapshot removed from publish
    CS->>NPM: Publish packages under dist-tag
    NPM-->>CS: Published
    CS-->>GHA: Published version returned
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant GHA as GitHub Actions
    participant CS as Changesets CLI
    participant NPM as npm Registry

    Note over GHA,NPM: Preview Release Workflow

    GHA->>CS: pnpm changeset version --snapshot snapshot-tag
    CS-->>GHA: Packages versioned with snapshot suffix

    GHA->>CS: pnpm changeset publish --no-git-tag --tag dist-tag
    Note over CS: Fixed - snapshot removed from publish
    CS->>NPM: Publish packages under dist-tag
    NPM-->>CS: Published
    CS-->>GHA: Published version returned
Loading

Reviews (1): Last reviewed commit: "Address audit issues reported by OSV sca..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release preview GitHub Actions workflow to stop passing an invalid --snapshot flag to changeset publish (snapshotting is handled during changeset version). It also updates the workspace astro catalog version and refreshes the lockfile accordingly.

Changes:

  • Remove --snapshot from pnpm changeset publish in the release_preview workflow.
  • Bump astro in the pnpm catalog from ^6.3.3 to ^6.4.7.
  • Regenerate pnpm-lock.yaml to reflect the updated astro (and transitive dependency) versions.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pnpm-workspace.yaml Updates the catalog-pinned astro version.
pnpm-lock.yaml Lockfile refresh to reflect astro@6.4.7 and related transitive updates.
.github/workflows/release_preview.yml Fixes CI by removing the invalid --snapshot argument from changeset publish.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -209,9 +209,8 @@ jobs:
run: |
# Publish with changesets using snapshot mode
Comment thread pnpm-workspace.yaml
"@types/react": 19.2.7
"@types/react-dom": 19.2.3
astro: ^6.3.3
astro: ^6.4.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants