Skip to content

Remove invalid flag from changeset publish script#2306

Merged
tk-o merged 1 commit into
mainfrom
fix/changesets-publish-args-2
Jun 16, 2026
Merged

Remove invalid flag from changeset publish script#2306
tk-o merged 1 commit into
mainfrom
fix/changesets-publish-args-2

Conversation

@tk-o

@tk-o tk-o commented Jun 16, 2026

Copy link
Copy Markdown
Member

This is a follow up PR to #2304 addressing one last CI run issue where changeset publish command was used with an invalid --snapshot argument.

Copilot AI review requested due to automatic review settings June 16, 2026 18:37
@tk-o tk-o requested a review from a team as a code owner June 16, 2026 18:37
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Jun 16, 2026 6:39pm
enskit-react-example.ensnode.io Ready Ready Preview, Comment Jun 16, 2026 6:39pm
ensnode.io Ready Ready Preview, Comment Jun 16, 2026 6:39pm
ensrainbow.io Ready Ready Preview, Comment Jun 16, 2026 6:39pm

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 759b0bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This follow-up PR resolves a CI failure by removing an invalid --snapshot flag from the changeset publish invocation used for snapshot releases, aligning the repo’s release scripts with current @changesets/cli argument validation.

Changes:

  • Remove unsupported --snapshot argument from the changeset:publish:next script.
  • Keep snapshot publishing behavior via --tag next (and --no-git-tag) intact for the snapshot workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the invalid --snapshot flag from the changeset:publish:next script in package.json. The --snapshot flag is only valid for changeset version, not changeset publish, so its presence was causing CI failures.

  • The changeset:publish:next script now correctly uses changeset publish --no-git-tag --tag next, which is the documented pattern for publishing snapshot releases.
  • The companion changeset:next script (changeset version --snapshot next) is unchanged and correctly uses --snapshot on the version subcommand.

Confidence Score: 5/5

This is a safe, surgical one-line fix to a CI script that removes an unsupported flag from changeset publish.

The change removes a single invalid flag (--snapshot) from the changeset:publish:next npm script. The official changesets documentation confirms --snapshot belongs on changeset version, not changeset publish. The remaining flags (--no-git-tag --tag next) are the correct documented form. No logic, application code, or build output is affected.

No files require special attention; the change is confined to a single script line in package.json.

Important Files Changed

Filename Overview
package.json Removes invalid --snapshot flag from changeset publish invocation; the remaining flags (--no-git-tag --tag next) are the correct documented pattern for snapshot publishing.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Dev as Developer/CI
    participant CS as changeset CLI
    participant NPM as npm Registry

    Note over Dev,NPM: Snapshot release workflow

    Dev->>CS: changeset version --snapshot next
    CS-->>Dev: Bumps versions to snapshot format (e.g. 0.0.0-next-TIMESTAMP)

    Dev->>CS: changeset publish --no-git-tag --tag next
    Note over CS: (formerly also had invalid --snapshot flag)
    CS->>NPM: Publishes packages with "next" dist-tag
    CS-->>Dev: Published (no git tags created)
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Dev as Developer/CI
    participant CS as changeset CLI
    participant NPM as npm Registry

    Note over Dev,NPM: Snapshot release workflow

    Dev->>CS: changeset version --snapshot next
    CS-->>Dev: Bumps versions to snapshot format (e.g. 0.0.0-next-TIMESTAMP)

    Dev->>CS: changeset publish --no-git-tag --tag next
    Note over CS: (formerly also had invalid --snapshot flag)
    CS->>NPM: Publishes packages with "next" dist-tag
    CS-->>Dev: Published (no git tags created)
Loading

Reviews (1): Last reviewed commit: "Remove invalid flag from `changeset publ..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1bf7bc61-0195-48b9-880d-820c7d397d37

📥 Commits

Reviewing files that changed from the base of the PR and between 15a8edf and 759b0bb.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

In package.json, the changeset:publish:next script is updated to run changeset publish --no-git-tag --tag next, removing the previous --snapshot flag from the publish command.

Changes

Publish Script Update

Layer / File(s) Summary
Remove --snapshot, add --no-git-tag --tag next
package.json
The changeset:publish:next script switches from snapshot publish behavior to a standard publish invocation using --no-git-tag --tag next.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • namehash/ensnode#2304: Directly related — also updates the changeset publish invocation to remove the --snapshot flag while keeping --no-git-tag and --tag arguments.

Poem

🐇 A flag was swapped, one tiny line,
--snapshot gone, now --tag next shines!
No git tag left, just "next" in place,
A cleaner publish, a tidier space.
Hop hop hooray for one-line grace! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. While it mentions the change and references a related issue, it lacks the required sections from the template: Summary, Why, Testing, and Pre-Review Checklist. Expand the description to include all required template sections: a bulleted summary of changes, explanation of why the change exists, testing methodology, and the pre-review checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing an invalid flag from the changeset publish script, which matches the core modification in package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/changesets-publish-args-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tk-o tk-o merged commit 5e2d77d into main Jun 16, 2026
22 checks passed
@tk-o tk-o deleted the fix/changesets-publish-args-2 branch June 16, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants