fix: add validation method and error message#3382
Merged
Merged
Conversation
Chartman123
added
bug
Chartman123
added
2. developing
Chartman123
force-pushed
the
fix/1586-validate-dropdown
branch
from
5a9b9c2 to
3c8d2d0
Compare
Chartman123
changed the title
Chartman123
added
3. to review
Koc
reviewed
Jun 6, 2026
Koc
approved these changes
Jun 6, 2026
pringelmann
approved these changes
Jun 8, 2026
pringelmann
left a comment
pringelmann
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Would be nice to have an E2E test to cover this new behavior, but its not a blocker. (maybe ask Copilot to do it)
Chartman123
force-pushed
the
fix/1586-validate-dropdown
branch
2 times, most recently
from
b4c38db to
0f125fa
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
fix/1586-validate-dropdown
branch
from
0f125fa to
7e9b52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1586 and fixes #1255 by adding a validate() function to all question types.
This improves the error message handling for required questions that have not been answered.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de