[ADD] estate: initial module setup by dhsri-odoo · Pull Request #1330 · odoo/tutorials

dhsri-odoo · 2026-06-05T09:24:29Z

Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.

robodoo · 2026-06-05T09:24:32Z

bit-odoo

Hello @dhsri-odoo
Good Work!

Can you please follwe the proper commit message guidelines and also improve your pr description?

Thanks

bit-odoo · 2026-06-17T08:48:43Z

Please follow the coding guidelines.
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#python

bit-odoo · 2026-06-17T08:49:11Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property,estate.property,model_estate_property,base.group_user,1,1,1,1


Should be one empty line at the end of the file.

bit-odoo · 2026-06-17T08:49:23Z

+            </search>
+        </field>
+    </record>
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-06-17T08:49:27Z

+
+
+    </menuitem>
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-06-17T08:50:00Z

+            </form>
+        </field>
+    </record>
+    <record id="estate_property_search" model="ir.ui.view">


It is good to have one empty line before it for better visibility.

bit-odoo · 2026-06-17T08:50:35Z

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+


unneccary diff.

bit-odoo · 2026-06-17T08:50:39Z

+
+    <menuitem id="estate_property_menu" name="real estate" action="estate_property_action"
+        web_icon="estate,static/description/icon.png">
+


unneccary diff.

bit-odoo · 2026-06-17T08:50:43Z

+
+        <menuitem name="sales" id="estate_sales_property" action="estate_property_action" />
+        <menuitem name="crm" id="estate_crm_property" action="estate_property_action"/>
+


unneccary diff.

bit-odoo · 2026-06-17T08:50:51Z

+    <record id="estate_list_property" model="ir.ui.view">
+        <field name="name">estate</field>
+        <field name="model">estate.property</field>
+


unneccary diff.

dhsri-odoo · 2026-06-18T04:30:12Z

Got it. I will follow the guidelines and improve the PR description on the next push.
Thanks!

bit-odoo

Hello,
Can you please follwe the coding guidelines?
You haven't made any changes to my last review. Please adapt that suggestion.

Thanks

bit-odoo · 2026-06-26T10:28:50Z

indentation issue.

bit-odoo · 2026-06-26T10:31:38Z

indentation issue.

bit-odoo · 2026-06-26T11:22:50Z

+from odoo import models, fields
+from dateutil.relativedelta import relativedelta
+
+class EstateProperty(models.Model):


should be 2 empty lines before it.

bit-odoo · 2026-06-26T11:25:49Z

+
+
+
+


unneccary empty lines.

bit-odoo · 2026-06-26T11:26:02Z

+    date_availability = fields.Date(
+        copy=False, default=fields.Date.today() + relativedelta(months=3)
+    )
+


unneccary empty line.

bit-odoo · 2026-06-26T11:26:07Z

+
+    expected_price = fields.Float(required=True)
+    selling_price = fields.Float(readonly=True, copy=False)
+


unneccary empty line.

bit-odoo · 2026-06-26T11:26:11Z

+    facades = fields.Integer()
+    garage = fields.Boolean()
+    garden = fields.Boolean()
+


unneccary empty line.

bit-odoo · 2026-06-26T11:26:16Z

+    garden = fields.Boolean()
+
+    garden_area = fields.Integer()
+


unneccary empty line.

bit-odoo · 2026-06-26T11:26:38Z

+            ("cancelled", "Cancelled"),
+        ]
+    )
+


unneccary empty line.

bit-odoo · 2026-06-26T11:26:41Z

+
+    language= fields.selection([
+        ('language','Language'),('hindi','Hindi')
+    ])


Should be one empty line at the end of the file.

Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.

The estate module metadata did not follow the expected manifest format. This update corrects the author and license values and adjusts the module definition so the module can be loaded consistently.

Add'Estate properties need a clear lifecycle to reflect their progress from creation to sale or cancellation. Add a required state field with a default value and prevent it from being copied when duplicating a property.s a state field to estate properties with lifecycle stages Configure default value, required constraint, and disable copying.

Estate properties need a dedicated interface to make their information easier to create, review, and filter. Add a form view to organize property details and a search view to filter available properties and group them by postcode. Update the property action and manifest to load the new views.

…o data EM This commit introduces dedicated offer and tag models with the necessary views, actions, menus, and access rights. Properties can now be associated with multiple tags and offers

Implement computed fields and onchange support to keep derived property values synchronized automatically and improve the user experience during data entry. This change introduces computed fields for total area and best offer price, an inverse method for offer validity and onchange logic to populate garden defaults.

Remove the custom search implementation to keep the estate module aligned with the tutorial implementation and avoid maintaining unnecessary search logic for computed fields.

Undo changes of estate form view

Add a kanban view for the estate properties so that users can visually manage and track properties along their sales pipeline. The properties are grouped by their status (New, Offer Received, Offer Accepted, Sold, Cancelled). To ensure all status columns are displayed even when empty, a custom `_read_group_stage_ids` expander is added to the state selection field.

bit-odoo reviewed Jun 17, 2026

View reviewed changes

bit-odoo reviewed Jun 26, 2026

View reviewed changes

[ADD] estate: initial module setup

0f7b88b

Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.

dhsri-odoo force-pushed the 19.0-tutorials-dhsri branch from 4ba0bea to 122a6df Compare July 2, 2026 04:44

dhsri-odoo added 8 commits July 2, 2026 10:22

[IMP] estate: resolve missing error of author and license

57f1eae

The estate module metadata did not follow the expected manifest format. This update corrects the author and license values and adjusts the module definition so the module can be loaded consistently.

[IMP] estate: add property offers and tags models and views & Add dem…

c300665

…o data EM This commit introduces dedicated offer and tag models with the necessary views, actions, menus, and access rights. Properties can now be associated with multiple tags and offers

[IMP] estate: remove computed field search support

97c8d3a

Remove the custom search implementation to keep the estate module aligned with the tutorial implementation and avoid maintaining unnecessary search logic for computed fields.

[IMP] estate: remove estate form and manifest

af7806d

Undo changes of estate form view

[WIP]

0a841e7

dhsri-odoo force-pushed the 19.0-tutorials-dhsri branch from 122a6df to 0a841e7 Compare July 2, 2026 05:09

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property,estate.property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

		@@ -0,0 +1,27 @@
		<?xml version="1.0" encoding="utf-8"?>
		<odoo>


		<menuitem id="estate_property_menu" name="real estate" action="estate_property_action"
		web_icon="estate,static/description/icon.png">


		<menuitem name="sales" id="estate_sales_property" action="estate_property_action" />
		<menuitem name="crm" id="estate_crm_property" action="estate_property_action"/>


		expected_price = fields.Float(required=True)
		selling_price = fields.Float(readonly=True, copy=False)

Uh oh!

Conversation

dhsri-odoo commented Jun 5, 2026

Uh oh!

robodoo commented Jun 5, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhsri-odoo commented Jun 18, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants