feat(fastapi): add py.typed marker#4685
Conversation
PEP 561 requires this marker inside the distributed package to indicate that downstream users may consume its inline type annotations.
228b36d to
5a17adf
Compare
|
@xrmx could you please take a look? |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
@xrmx ping. |
|
Thanks for this @tamird ! Please could you clarify a bit more on what this does, and maybe why this instrumentation library in particular? |
|
@tammy-baylis-swi it does what's on the tin. Why this one? Because it's the one I ran into and needed. |
The |
|
I don't know if it's type-checked in your CI, but it does have type annotations. |
Yeah I mean that the type annotations may not be correct if they are not typechecked. |
Would you be more comfortable if this PR also added type checking? |
Add the PEP 561 marker to the FastAPI instrumentation package so downstream type checkers consume its inline annotations.
Place the marker alongside the import package so Hatch includes it in both wheel and source distributions.
This is a non-breaking typing metadata change and does not require a core repository change.