Migrate GCP resource detector (opentelemetry-resourcedetector-gcp) to contrib#4749
Merged
xrmx merged 12 commits intoJul 15, 2026
Merged
Conversation
xrmx
reviewed
Jul 13, 2026
xrmx
left a comment
xrmx
left a comment
Contributor
There was a problem hiding this comment.
Is this a move of the current one or does it have some changes? I am grateful for the rename of the entry point :)
Contributor
Author
|
Just a move of the existing one.. I had to make some minor changes to fix the pre commit checks (changed the license, run precommit) |
xrmx
reviewed
Jul 14, 2026
xrmx
approved these changes
Jul 14, 2026
xrmx
left a comment
xrmx
left a comment
Contributor
There was a problem hiding this comment.
Small nits in the README but LGTM
emdneto
reviewed
Jul 14, 2026
emdneto
left a comment
emdneto
left a comment
Member
There was a problem hiding this comment.
Can you add the package opentelemetry-resourcedetector-gcp in here? https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/workflows/package-prepare-release.yml#L10 and also add in the others package-*.yml workflows?
emdneto
approved these changes
Jul 14, 2026
Contributor
Author
|
I think the workflow stuff is best done in a separate PR after we move the package name on PyPi over |
github-project-automation
Bot
moved this from Ready for review
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the GCP resource detector to this repo.
We'll have to transfer ownership of this package name in PyPi..
I started the version in this repo at
__version__ = "1.13.0.dev"because the latest released version on PyPi is1.12.0a0Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.