Update log, metrics and trace exporters to return response code in addition to success/failure flag#5295
Open
rads-1996 wants to merge 5 commits into
Open
Update log, metrics and trace exporters to return response code in addition to success/failure flag#5295rads-1996 wants to merge 5 commits into
rads-1996 wants to merge 5 commits into
Conversation
…dition to success/failure flag
Contributor
|
I don't think this is something we want to support, given that processors don't currently use this value. Furthermore, this would be a breaking change to exporters, which is not something we want to introduce unnecessarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surface the underlying HTTP response code from the trace, span, and metric exporters in
opentelemetry-exporter-otlp-proto-http.The OTLP HTTP exporters only return a coarse SUCCESS/FAILURE status from export(). When a failure occurs, callers have no programmatic way to determine why it failed — was it a 4xx client error, a 5xx server error, a transient network issue, etc. Without that signal, downstream code can't make informed decisions (e.g. whether to retry, alert, or fail fast), and operators have no insight beyond logs.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: