Parallel HDF5: Try fixing strict collective requirements of HDF5 >= 2.0#1862
Open
franzpoeschel wants to merge 36 commits into
Open
Parallel HDF5: Try fixing strict collective requirements of HDF5 >= 2.0#1862franzpoeschel wants to merge 36 commits into
franzpoeschel wants to merge 36 commits into
Conversation
This was referenced Mar 11, 2026
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
2 times, most recently
from
March 12, 2026 15:14
11ba7aa to
b6ea4b4
Compare
This was referenced Mar 13, 2026
Merged
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
2 times, most recently
from
March 16, 2026 10:12
a5c1985 to
bcb55ef
Compare
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
3 times, most recently
from
March 27, 2026 10:19
48b4c2a to
07fb558
Compare
| } | ||
| } // namespace | ||
|
|
||
| std::future<void> AbstractIOHandlerImpl::flush(FlushLevel l) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
from
March 30, 2026 13:57
4abee4d to
38d3852
Compare
Check notice
Code scanning / CodeQL
Unused static function Note test
Check notice
Code scanning / CodeQL
Unused static function Note test
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
from
March 30, 2026 16:37
6b2454b to
4fcb328
Compare
This was referenced Mar 30, 2026
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
from
April 7, 2026 15:37
4fcb328 to
3812746
Compare
franzpoeschel
force-pushed
the
fix-parallel-hdf5
branch
from
July 20, 2026 12:52
bf165a1 to
bc00986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that HDF5 has become quite a bit pickier about metadata definitions in parallel setups with versions 2.0 and 2.1, leading to hangups.
Earlier, it was enough to define them consistently across ranks, now we apparently have to keep the exact same order of operations.
This is bad for the Span API which runs internal flushes for structure setup.
resetDataset()flushParticlesPathandflushMeshesPathfunctions, these unnecessarily leaked attribute flushes into the structure setupresetDataset(). Best idea: add the new logic to a new API callcommitStructuralSetup()or so.defer_typecommitStructuralSetup()Diff at https://github.com/franzpoeschel/openPMD-api/compare/defaults-upon-close...fix-parallel-hdf5?expand=1