Skip to content

HYPERFLEET-1232 - docs: trim sentinel.md to high-level design document#183

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
rafabene:HYPERFLEET-1232-move-sentinel-docs
Jul 10, 2026
Merged

HYPERFLEET-1232 - docs: trim sentinel.md to high-level design document#183
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
rafabene:HYPERFLEET-1232-move-sentinel-docs

Conversation

@rafabene

@rafabene rafabene commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Trim hyperfleet/components/sentinel/sentinel.md from ~1220 lines to ~250 lines, keeping only the high-level design document (What/Why, Architecture diagrams, Decision Logic concept, Trade-offs, Alternatives Considered, Post-MVP)
  • Remove detailed operational/reference content that now lives in the sentinel repo (hyperfleet-sentinel#222): Message Decision details, CEL Function Reference, Adapter Status Update Contract, Status Tracking, Service Components, Decision Engine Test Scenarios, configuration YAML examples
  • Update cross-references in condition-mapping-design.md, glossary.md, and v0.2.0-to-v1.0.0-upgrade-guide.md to point to the sentinel repo for detailed content
  • Add links at the top of sentinel.md pointing to the sentinel repo docs (config, operator guide, decision engine reference, multi-instance deployment)

Per Angel Marin's review comment on PR #154: "IMO all this information belongs to the sentinel repository, and we keep only high level information in this one."

Test plan

  • Verify sentinel.md retains all required component doc sections (What/Why, How, Trade-offs, Alternatives Considered)
  • Verify cross-references to sentinel repo resolve correctly
  • Verify no broken internal links (./hack/linkcheck.sh)
  • Confirm companion PR hyperfleet-sentinel#222 contains all moved content

@openshift-ci openshift-ci Bot requested review from aredenba-rh and pnguyen44 July 9, 2026 18:58
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Documentation-only changes update four Markdown files. The Sentinel design document was condensed, its decision logic and resource filtering sections were revised, and an inline multi-instance YAML example was replaced with a documentation link. Related references in the API service design, glossary, and upgrade guide now point to the Sentinel Decision Engine Reference.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed Only markdown changed; no slog/logr/zap/fmt.Print* calls with token/password/credential/secret fields or interpolations. CWE-532 not present.
No Hardcoded Secrets ✅ Passed PASS: No CWE-798/CWE-321 indicators in the PR docs; scans found no secret assignments, embedded creds, or long base64, only documentation samples/links.
No Weak Cryptography ✅ Passed Only Markdown docs changed; no code touched and no banned crypto primitives or secret comparisons were found in modified files (CWE-327/CWE-208).
No Injection Vectors ✅ Passed Markdown-only changes; no exec.Command, template.HTML, yaml.Unmarshal, or query fmt.Sprintf patterns found (CWE-89/78/79/502).
No Privileged Containers ✅ Passed PASS: PR only changes Markdown docs; no Kubernetes/Helm/Dockerfile changes or privilege flags found, so no CWE-284/CWE-269 exposure.
No Pii Or Sensitive Data In Logs ✅ Passed Only Markdown docs changed; no slog/logr/zap/fmt.Print logging statements or PII-bearing log payloads were added. CWE-532 not implicated.
Title check ✅ Passed The title clearly matches the main change: trimming sentinel.md to a high-level design document.
Description check ✅ Passed The description is directly related to the documented doc trim and link updates in this changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

- [Hardcoded Decision Logic](#hardcoded-decision-logic)
- [Kubernetes Controller Pattern](#kubernetes-controller-pattern)
- [Post-MVP Enhancements](#post-mvp-enhancements)
- [Advanced Alerting](#advanced-alerting)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafabene rafabene Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — Post-MVP Enhancements is design/roadmap content, so it stays here in the architecture repo. I only removed the sub-section of it from the TOC.

@rafabene rafabene force-pushed the HYPERFLEET-1232-move-sentinel-docs branch from 99ad8f7 to a5df886 Compare July 10, 2026 12:44
@rafabene

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@rafabene

Copy link
Copy Markdown
Member Author

/retest

Move detailed operational/reference content to the sentinel repo
(openshift-hyperfleet/hyperfleet-sentinel#222) and keep only the
high-level design document per the component doc standard.

Removed sections (now in sentinel repo docs/decision-engine.md):
- Message Decision details, CEL Function Reference
- Adapter Status Update Contract, Status Tracking
- Service Components, Decision Engine Test Scenarios
- Configuration YAML examples, Resource Filtering examples

Retained sections: What & Why, Architecture (diagrams), Decision
Logic (conceptual), Trade-offs, Alternatives Considered, Post-MVP.

Also updates cross-references in condition-mapping-design.md,
glossary.md, and v0.2.0-to-v1.0.0-upgrade-guide.md to point to
the sentinel repo for detailed content.
@rafabene rafabene force-pushed the HYPERFLEET-1232-move-sentinel-docs branch from a5df886 to 24ef63b Compare July 10, 2026 13:36
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tirthct

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 06d7ab3 into openshift-hyperfleet:main Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants