HYPERFLEET-1232 - docs: trim sentinel.md to high-level design document#183
Conversation
📝 WalkthroughWalkthroughDocumentation-only changes update four Markdown files. The Sentinel design document was condensed, its decision logic and resource filtering sections were revised, and an inline multi-instance YAML example was replaced with a documentation link. Related references in the API service design, glossary, and upgrade guide now point to the Sentinel Decision Engine Reference. Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
| - [Hardcoded Decision Logic](#hardcoded-decision-logic) | ||
| - [Kubernetes Controller Pattern](#kubernetes-controller-pattern) | ||
| - [Post-MVP Enhancements](#post-mvp-enhancements) | ||
| - [Advanced Alerting](#advanced-alerting) |
There was a problem hiding this comment.
Hmm, seems like this section is still there: https://github.com/rafabene/hyperfleet-architecture/blob/99ad8f7217c5dafe9d115a02068efd7389a06200/hyperfleet/components/sentinel/sentinel.md#advanced-alerting
There was a problem hiding this comment.
Good catch — Post-MVP Enhancements is design/roadmap content, so it stays here in the architecture repo. I only removed the sub-section of it from the TOC.
99ad8f7 to
a5df886
Compare
|
/retest |
1 similar comment
|
/retest |
Move detailed operational/reference content to the sentinel repo (openshift-hyperfleet/hyperfleet-sentinel#222) and keep only the high-level design document per the component doc standard. Removed sections (now in sentinel repo docs/decision-engine.md): - Message Decision details, CEL Function Reference - Adapter Status Update Contract, Status Tracking - Service Components, Decision Engine Test Scenarios - Configuration YAML examples, Resource Filtering examples Retained sections: What & Why, Architecture (diagrams), Decision Logic (conceptual), Trade-offs, Alternatives Considered, Post-MVP. Also updates cross-references in condition-mapping-design.md, glossary.md, and v0.2.0-to-v1.0.0-upgrade-guide.md to point to the sentinel repo for detailed content.
a5df886 to
24ef63b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tirthct The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
06d7ab3
into
openshift-hyperfleet:main
Summary
hyperfleet/components/sentinel/sentinel.mdfrom ~1220 lines to ~250 lines, keeping only the high-level design document (What/Why, Architecture diagrams, Decision Logic concept, Trade-offs, Alternatives Considered, Post-MVP)condition-mapping-design.md,glossary.md, andv0.2.0-to-v1.0.0-upgrade-guide.mdto point to the sentinel repo for detailed contentsentinel.mdpointing to the sentinel repo docs (config, operator guide, decision engine reference, multi-instance deployment)Per Angel Marin's review comment on PR #154: "IMO all this information belongs to the sentinel repository, and we keep only high level information in this one."
Test plan
sentinel.mdretains all required component doc sections (What/Why, How, Trade-offs, Alternatives Considered)./hack/linkcheck.sh)