Skip to content

MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089

Open
neha037 wants to merge 1 commit into
openshift:mainfrom
neha037:MG-272-hypershift-periodic-v2
Open

MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089
neha037 wants to merge 1 commit into
openshift:mainfrom
neha037:MG-272-hypershift-periodic-v2

Conversation

@neha037

@neha037 neha037 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a weekly HyperShift periodic CI job (e2e-aws-hypershift-operator-weekly) for the must-gather-operator on release-4.22
  • Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux image mirrors into the hosted cluster at creation time
  • Installs the operator from the Konflux FBC release catalog via optional-operators-subscribe
  • Includes nested management cluster provisioning, ICSP setup, KUBECONFIG switching, and full cleanup

Test plan

  • CI validation checks pass
  • /pj-rehearse triggers rehearsal of the HyperShift periodic job
  • Rehearsal: management cluster provisions, hosted cluster creates with ICSP, operator installs via OLM, e2e tests run

Supersedes #81737

🤖 Generated with Claude Code

Summary by CodeRabbit

This updates the ci-operator configuration for the must-gather-operator on the release-4.22 branch to support a new weekly HyperShift AWS E2E run, and adds the corresponding “multi-architecture latest” candidate release wiring.

  • Extends ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml:
    • Adds a releases.multi-latest candidate (architecture: multi, product: ocp, stream: nightly, version: "4.22").
    • Introduces e2e-aws-hypershift-operator-weekly with cron: '@Weekly':
      • Runs on the hypershift-aws cluster profile, using RELEASE_IMAGE_LATEST: release:multi-latest.
      • Enables ICSP via ENABLE_ICSP: "true" and installs the operator using Konflux FBC subscription (optional-operators-subscribe) into the must-gather-operator namespace (OO_PACKAGE: support-log-gather-operator, OO_CHANNEL: tech-preview, OO_TARGET_NAMESPACES: '!all').
      • Provisions a nested management cluster and uses the HyperShift chain hypershift-setup-nested-management-cluster + hypershift-aws-create, followed by post chains hypershift-dump, hypershift-aws-destroy, and hypershift-destroy-nested-management-cluster.
      • Adds Konflux image-mirror/ICSP setup (setup-konflux-icsp) that generates mgmt_icsp.yaml, plus guest kubeconfig setup (setup-guest-kubeconfig) that merges pull-secrets and sets KUBECONFIG.
      • Verifies the must-gather-operator rollout and runs make test-e2e using mounted case-management-creds, with a final cleanup via the destroy chains.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@neha037: This pull request references MG-272 which is a valid jira issue.

Details

In response to this:

Summary

  • Adds a weekly HyperShift periodic CI job (e2e-aws-hypershift-operator-weekly) for the must-gather-operator on release-4.22
  • Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux image mirrors into the hosted cluster at creation time
  • Installs the operator from the Konflux FBC release catalog via optional-operators-subscribe
  • Includes nested management cluster provisioning, ICSP setup, KUBECONFIG switching, and full cleanup

Test plan

  • CI validation checks pass
  • /pj-rehearse triggers rehearsal of the HyperShift periodic job
  • Rehearsal: management cluster provisions, hosted cluster creates with ICSP, operator installs via OLM, e2e tests run

Supersedes #81737

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a9fe6b78-c096-40f9-9e27-cf88ccdc344d

📥 Commits

Reviewing files that changed from the base of the PR and between 51caff2 and 6a0f1d2.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml

Walkthrough

Changes

Release 4.22 Hypershift testing

Layer / File(s) Summary
Multi-architecture candidate release
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
Adds the multi-latest nightly multi-architecture candidate for OCP 4.22.
Weekly AWS Hypershift end-to-end pipeline
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
Adds a weekly Hypershift test using the new release image, ICSP configuration, rollout verification, and make test-e2e.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WeeklyTest as e2e-aws-hypershift-operator-weekly
  participant Hypershift as hypershift-aws
  participant ICSP as setup-konflux-icsp
  participant Operator as must-gather-operator
  participant E2E as make test-e2e
  WeeklyTest->>Hypershift: Set up nested management cluster
  WeeklyTest->>ICSP: Write mgmt_icsp.yaml
  WeeklyTest->>Hypershift: Configure guest kubeconfig and pull-secret mirroring
  WeeklyTest->>Operator: Verify deployment rollout
  WeeklyTest->>E2E: Run end-to-end tests
  WeeklyTest->>Hypershift: Tear down the test environment
Loading

Possibly related PRs

  • openshift/release#82120: Updates OCP 4.22 nightly/candidate release image selection in another CI job configuration.

Suggested reviewers: tafhim, dustman9000

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The new hypershift weekly job pulls/subscribes via quay.io and mirrors registry.redhat.io images, so it still depends on public registry connectivity. Use only cluster-internal mirrors for all catalogs/images, or add [Skipped:Disconnected] if the job cannot run without public registry access.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a periodic HyperShift CI job for the 4.22 must-gather/support-log-gather operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes CI YAML job/config names; there are no It/Describe/Context/When test titles, dynamic or otherwise.
Test Structure And Quality ✅ Passed PR only changes CI job/config YAML; no Ginkgo test code was added or modified, so the Ginkgo-specific quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only adds ci-operator/job config; no Go/Ginkgo test files or new It/Describe/Context/When blocks were introduced, so nothing MicroShift-specific to flag.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds CI job/config; no new Ginkgo It/Describe/Context/When tests or SNO-sensitive test code were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI config/periodic job files changed; no deployment manifests, controllers, affinity, nodeSelector, replica, or PDB logic was introduced.
Ote Binary Stdout Contract ✅ Passed Only CI YAML changed; no process-level code or stdout writes were introduced, so the OTE stdout contract isn't impacted.
No-Weak-Crypto ✅ Passed The added YAML only configures CI jobs and secret/image-mirror handling; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed No privileged flags, host namespaces, allowPrivilegeEscalation, or root/securityContext settings were added in the changed CI config or periodic job manifests.
No-Sensitive-Data-In-Logs ✅ Passed No added step prints secret contents or enables xtrace; sensitive data is only read from mounted files and redirected to temp files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Tafhim and dustman9000 July 17, 2026 15:39
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neha037
Once this PR has been reviewed and has the lgtm label, please assign typeid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`:
- Around line 203-204: Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b09e4ae7-8c59-4413-b5cf-fae50903b530

📥 Commits

Reviewing files that changed from the base of the PR and between a710bb3 and 51caff2.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml

Comment on lines +203 to +204
- as: e2e-aws-hypershift-operator-weekly
cron: '@weekly'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Regenerate the Prow job for this new periodic test.

Adding this named cron test changes generated job configuration, but the PR includes only the source config. Run make update and commit the affected generated Prow job output before merge. As per coding guidelines, “run make update after changes to regenerate zz_generated_metadata and Prow jobs.”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`
around lines 203 - 204, Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.

Source: Coding guidelines

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@neha037: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neha037

neha037 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@neha037: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

…r 4.22

Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux
image mirrors into the hosted cluster at creation time. Installs the
operator from the Konflux FBC release catalog via optional-operators-subscribe.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@neha037
neha037 force-pushed the MG-272-hypershift-periodic-v2 branch from 51caff2 to 6a0f1d2 Compare July 19, 2026 11:36
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@neha037: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-must-gather-operator-release-4.22-ci-bundle-must-gather-operator-bundle openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-coverage openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-images openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-lint openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-test openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-validate-boilerplate openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-verify-deps openshift/must-gather-operator presubmit Ci-operator config changed
periodic-ci-openshift-must-gather-operator-release-4.22-e2e-aws-hypershift-operator-weekly N/A periodic Periodic changed
periodic-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator-weekly N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@neha037

neha037 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@neha037: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants