MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089
MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089neha037 wants to merge 1 commit into
Conversation
|
@neha037: This pull request references MG-272 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughChangesRelease 4.22 Hypershift testing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WeeklyTest as e2e-aws-hypershift-operator-weekly
participant Hypershift as hypershift-aws
participant ICSP as setup-konflux-icsp
participant Operator as must-gather-operator
participant E2E as make test-e2e
WeeklyTest->>Hypershift: Set up nested management cluster
WeeklyTest->>ICSP: Write mgmt_icsp.yaml
WeeklyTest->>Hypershift: Configure guest kubeconfig and pull-secret mirroring
WeeklyTest->>Operator: Verify deployment rollout
WeeklyTest->>E2E: Run end-to-end tests
WeeklyTest->>Hypershift: Tear down the test environment
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neha037 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`:
- Around line 203-204: Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b09e4ae7-8c59-4413-b5cf-fae50903b530
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
| - as: e2e-aws-hypershift-operator-weekly | ||
| cron: '@weekly' |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Regenerate the Prow job for this new periodic test.
Adding this named cron test changes generated job configuration, but the PR includes only the source config. Run make update and commit the affected generated Prow job output before merge. As per coding guidelines, “run make update after changes to regenerate zz_generated_metadata and Prow jobs.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`
around lines 203 - 204, Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.
Source: Coding guidelines
|
@neha037: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse |
|
@neha037: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…r 4.22 Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux image mirrors into the hosted cluster at creation time. Installs the operator from the Konflux FBC release catalog via optional-operators-subscribe. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
51caff2 to
6a0f1d2
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@neha037: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Summary
e2e-aws-hypershift-operator-weekly) for the must-gather-operator on release-4.22hypershift-aws-createchain withENABLE_ICSP=trueto bake Konflux image mirrors into the hosted cluster at creation timeoptional-operators-subscribeTest plan
/pj-rehearsetriggers rehearsal of the HyperShift periodic jobSupersedes #81737
🤖 Generated with Claude Code
Summary by CodeRabbit
This updates the
ci-operatorconfiguration for the must-gather-operator on therelease-4.22branch to support a new weekly HyperShift AWS E2E run, and adds the corresponding “multi-architecture latest” candidate release wiring.ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml:releases.multi-latestcandidate (architecture: multi,product: ocp,stream: nightly,version: "4.22").e2e-aws-hypershift-operator-weeklywithcron: '@Weekly':hypershift-awscluster profile, usingRELEASE_IMAGE_LATEST: release:multi-latest.ENABLE_ICSP: "true"and installs the operator using Konflux FBC subscription (optional-operators-subscribe) into themust-gather-operatornamespace (OO_PACKAGE: support-log-gather-operator,OO_CHANNEL: tech-preview,OO_TARGET_NAMESPACES: '!all').hypershift-setup-nested-management-cluster+hypershift-aws-create, followed by post chainshypershift-dump,hypershift-aws-destroy, andhypershift-destroy-nested-management-cluster.setup-konflux-icsp) that generatesmgmt_icsp.yaml, plus guest kubeconfig setup (setup-guest-kubeconfig) that merges pull-secrets and setsKUBECONFIG.must-gather-operatorrollout and runsmake test-e2eusing mountedcase-management-creds, with a final cleanup via the destroy chains.