feat(rhoso-apps): add ignoreDifferences support to Application template#61
Open
aharivel wants to merge 1 commit into
Open
Conversation
Add optional spec.ignoreDifferences to the rendered ArgoCD Application resources. This is needed for deployments where operator-mutated fields (e.g. OpenStackControlPlane /spec/tls, BareMetalHost /status) cause perpetual OutOfSync without ignoreDifferences. Changes: - values.schema.json: add ignoreDifferences array (items: object with additionalProperties) to the application definition; also allow the base finalizer string (without /background or /foreground suffix) - _helpers.tpl: add rhoso-apps.ignoreDifferences helper - application.yaml: render ignoreDifferences when present - application_test.yaml: add 3 tests (omitted when unset, jsonPointers, jqPathExpressions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anthony Harivel <aharivel@redhat.com>
cjeanner
approved these changes
Jun 24, 2026
cjeanner
left a comment
cjeanner
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. @pinikomarov care to have a look as well? We might need a 0.3.1 tag once it's merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional spec.ignoreDifferences to the rendered ArgoCD Application resources. This is needed for deployments where operator-mutated fields (e.g. OpenStackControlPlane /spec/tls, BareMetalHost /status) cause perpetual OutOfSync without ignoreDifferences.
Changes: