Skip to content

[AI-FSSDK] [FSSDK-12750] Use attribute id instead of key for CMAB prediction requests#648

Merged
muzahidul-opti merged 4 commits into
masterfrom
ai/raju-opti/FSSDK-12750-cmab-attribute-id-fix
Jul 8, 2026
Merged

[AI-FSSDK] [FSSDK-12750] Use attribute id instead of key for CMAB prediction requests#648
muzahidul-opti merged 4 commits into
masterfrom
ai/raju-opti/FSSDK-12750-cmab-attribute-id-fix

Conversation

@raju-opti

@raju-opti raju-opti commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

The CMAB service was using attribute keys instead of attribute IDs when building the filtered attribute map for prediction requests. The CMAB prediction endpoint expects attribute IDs in the JSON payload, so this change corrects the map key from the attribute's key to its ID.

Changes

  • Updated the filtered attribute map in CmabService to use attribute ID as the dictionary key instead of attribute key
  • Updated all related test assertions and cache hash computations to use attribute IDs
  • Fixed a pre-existing bug in MockProjectConfig where an attribute was incorrectly added to attributeIdMap instead of attributeKeyMap

Jira Ticket

FSSDK-12750

@coveralls

coveralls commented Jul 1, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 93.859%. remained the same — ai/raju-opti/FSSDK-12750-cmab-attribute-id-fix into master

@muzahidul-opti muzahidul-opti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 6ddb123 into master Jul 8, 2026
10 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the ai/raju-opti/FSSDK-12750-cmab-attribute-id-fix branch July 8, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants