pyscg-0009 - addressing issues described in #1053#1095
Conversation
Signed-off-by: s19110 <hubertdan24@gmail.com>
Signed-off-by: s19110 <hubertdan24@gmail.com>
|
Because I had to rename the original |
Signed-off-by: s19110 <hubertdan24@gmail.com>
BartKaras1128
left a comment
BartKaras1128
left a comment
There was a problem hiding this comment.
Left a few comments, looks good besides that!
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
first examples have nonmatching exploit sections.
2nd example is using cmd /c on windows, I provided an alternative code example using a powershell command that acts similar in windows to find . -exec in linux.
…09/README.md Co-authored-by: Bartlomiej Karas <moezarts@gmail.com> Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
…09/README.md Co-authored-by: Bartlomiej Karas <moezarts@gmail.com> Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
…09/README.md Co-authored-by: Bartlomiej Karas <moezarts@gmail.com> Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
…09/compliant01.py Co-authored-by: Bartlomiej Karas <moezarts@gmail.com> Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
…09/README.md Co-authored-by: Bartlomiej Karas <moezarts@gmail.com> Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
Signed-off-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com>
|
Thank you @myteron and @BartKaras1128 for the reviews! I have made changes to this PR to include your suggestions. @myteron, I couldn't find the powershell command you mentioned in your comment. Could you please send it to me in another comment or suggestion? |
3 participants
I have added a new compliant code example that corresponds to
noncompliant01.py, changednoncompliant02.pyto include an attack for Windows OS, and changed the wording in theREADMEto reflect the new changes.this is to address #1053