feat: new api for compaction#429
Conversation
dkharms
force-pushed
the
0-fm-compaction-api
branch
from
1f7bfdb to
96ba81f
Compare
eguguchkin
force-pushed
the
275-fractions-snapshot
branch
from
e447d7f to
8335b37
Compare
eguguchkin
force-pushed
the
275-fractions-snapshot
branch
from
b3f54cd to
8dd3663
Compare
dkharms
force-pushed
the
0-fm-compaction-api
branch
from
96ba81f to
d657428
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
- Coverage 70.83% 70.60% -0.24%
==========================================
Files 225 225
Lines 17514 17577 +63
==========================================
+ Hits 12406 12410 +4
- Misses 4183 4240 +57
- Partials 925 927 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
dkharms
force-pushed
the
0-fm-compaction-api
branch
from
d657428 to
58ee0db
Compare
| claimed = append(claimed, s) | ||
| } | ||
|
|
||
| r.rebuildSnapshot() |
There was a problem hiding this comment.
No need to rebuild the snapshot here — we're just moving from one queue to another, so the overall set of fractions hasn't changed.
| for _, f := range consumed { | ||
| info := f.Info() | ||
| r.stats.compacting.Sub(info) | ||
| delete(r.compacting, info.Name()) |
There was a problem hiding this comment.
Should we additionally check, for reliability, that such a fraction is indeed present in the compacting list?
There was a problem hiding this comment.
Yeah, consistency check won't hurt -- I've added it.
dkharms
force-pushed
the
0-fm-compaction-api
branch
from
9c50ff8 to
b6e78ca
Compare
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
4 participants
Description
In this PR I've implemented all necessary API for compaction. And also changed visibility of all methods inside
fracmanagerpackage since they should not be exported.I expect that there will be slight tweaks and changes to this API (e.g. method signature change) but the whole idea will be the same.
If you have used LLM/AI assistance please provide model name and full prompt: