Skip to content

[FEATURE]: add timezone logic to the dashbaord toolbar#177

Merged
jgbernalp merged 1 commit into
mainfrom
dashbaord_toolbar_timezone_logic
Jun 24, 2026
Merged

[FEATURE]: add timezone logic to the dashbaord toolbar#177
jgbernalp merged 1 commit into
mainfrom
dashbaord_toolbar_timezone_logic

Conversation

@shahrokni

@shahrokni shahrokni commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Relates to perses/perses#3916 and perses/perses#1382

Description

This feature lets users persist the desired dashboard time zone in the Dashboard Spec
Similar to other toolbar properties, the new default time zone needs to be confirmed by the user before it is persisted.

Before save action

image

PUT request payload

image

The time zone logic

The logic always checks if there is any persisted dashboard.spec.timezone. If there is no persisted time zone, the logic tries to pick the user preferred time zone. Finally, if nothing is available the logic sets the time zone to local.
The user preferences time zone is being developed and will be persisted in a local storage. Currently, we have no plan to save the user preferences on the BE side.

The logic is coming from here

So that's what we are going to do: The timezone selector will take the value from the dashboard if exists, then if not it will take it from the user preferences, then if nothing it will take the timezone of the browser.

perses/perses#3916 (comment)

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@shahrokni

Copy link
Copy Markdown
Contributor Author

⚠️ NOT READY, WORK IN PROGRESS ...

@shahrokni shahrokni force-pushed the dashbaord_toolbar_timezone_logic branch 2 times, most recently from 8092c96 to 828119d Compare June 24, 2026 14:23
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the dashbaord_toolbar_timezone_logic branch from baa857d to 55e5270 Compare June 24, 2026 14:54
@shahrokni shahrokni marked this pull request as ready for review June 24, 2026 14:55
@shahrokni shahrokni requested a review from a team as a code owner June 24, 2026 14:55
@shahrokni shahrokni requested review from jgbernalp and removed request for a team June 24, 2026 14:57
@jgbernalp jgbernalp merged commit bc87296 into main Jun 24, 2026
12 checks passed
@jgbernalp jgbernalp deleted the dashbaord_toolbar_timezone_logic branch June 24, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants