Fix parallel run total durations#2802
Closed
nohwnd wants to merge 3 commits into
Closed
Conversation
Parallel runs summed container durations, which overstates the run because the files overlap. Use the wall-clock duration (RunEnd - RunStart) for Run.Duration and leave the per-phase totals blank in parallel mode. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The per-phase totals are cumulative measurements of user, framework and discovery time, so they stay valid when files overlap - they just add up to the total work done across the overlapping workers. Only the wall-clock run total needs to be measured fresh, because summing the overlapping container durations overstates it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tions # Conflicts: # tst/Pester.RSpec.Parallel.ts.ps1
Member
Author
|
Superseded by #2807. That one measures the run wall-clock for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container durations were summed, which overstates a parallel run since the files overlap in wall-clock time. Measure the actual elapsed time for
Run.Durationin parallel instead.The per-phase totals (user, framework, discovery) are still summed rather than blanked - they are cumulative work measurements, so they stay meaningful across the overlapping workers and add up to the total container work.
Added a parallel duration test.
Fix #2794