core: raise clear error when OpenSSL library is not found#318
Open
Bortlesboat wants to merge 2 commits into
Open
core: raise clear error when OpenSSL library is not found#318Bortlesboat wants to merge 2 commits into
Bortlesboat wants to merge 2 commits into
Conversation
On Windows, ctypes.util.find_library() can return None for all candidate library names. Passing None to LoadLibrary() raises a confusing TypeError. Check for None first and raise an EnvironmentError with an actionable message instead. Fixes petertodd#316
Author
|
Added an isolated subprocess regression for the missing-library path. It verifies that all failed lookups now produce the actionable EnvironmentError instead of reaching LoadLibrary(None); the full key test module passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, every
ctypes.util.find_library()candidate can returnNone. Passing that value directly toctypes.cdll.LoadLibrary()raises a confusingTypeError.Check the resolved path first and raise an actionable
EnvironmentErrorexplaining that OpenSSL must be installed and discoverable.Fixes #316.
Verification
Noneand asserts the exact public error.python -m unittest bitcoin.tests.test_key -v— 2 passed.