Skip to content

tiflash-proxy-next-gen: bind data key id from encryption meta#10948

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hbisheng:bh-bump-proxy
Jul 3, 2026
Merged

tiflash-proxy-next-gen: bind data key id from encryption meta#10948
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
hbisheng:bh-bump-proxy

Conversation

@hbisheng

@hbisheng hbisheng commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #10952

Problem Summary:

What is changed and how it works?

Bump submodule contrib/tiflash-proxy-next-gen to pick up next-gen proxy data key id binding from encryption meta.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Tested tiflash write can read data key generated by latest-release-tikv.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated a bundled subproject to a newer revision, which may include underlying improvements and fixes.

@ti-chi-bot

ti-chi-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7473511b-4127-48a2-968e-322ba3bac0f3

📥 Commits

Reviewing files that changed from the base of the PR and between 63cff9a and e6f633b.

📒 Files selected for processing (1)
  • contrib/tiflash-proxy-next-gen

📝 Walkthrough

Walkthrough

This PR updates the contrib/tiflash-proxy-next-gen submodule reference to a new commit hash, replacing the previous commit pointer.

Changes

Submodule Update

Layer / File(s) Summary
Submodule commit bump
contrib/tiflash-proxy-next-gen
Updates the subproject commit pointer from 5fa3872069ec9ee85a9faf633030a0ee9d090197 to 45187f537fd50287eb46d067960d00d7adbdb11e.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • pingcap/tiflash#10884: Both PRs update the contrib/tiflash-proxy-next-gen submodule pointer to different commit targets.

Suggested reviewers: yongman, Lloyd-Pottiger

Poem

A tiny hop, a pointer new,
One commit hash traded for a view,
The proxy sleeps in updated code,
While this rabbit thumps the road. 🐇
Onward to the next-gen burrow we go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: a tiflash-proxy-next-gen bump to bind data key IDs from encryption metadata.
Description check ✅ Passed The description mostly follows the template with issue reference, summary, tests, side effects, docs, and release note sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2026
…p#10948)

ref tidbcloud/cloud-storage-engine#5484

Bump submodule contrib/tiflash-proxy-next-gen to pick up next-gen proxy data key id binding from encryption meta.

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
@hbisheng hbisheng changed the title Bump tiflash proxy next gen tiflash-proxy-next-gen: bind data key id from encryption meta Jul 3, 2026
@hbisheng hbisheng marked this pull request as ready for review July 3, 2026 03:49
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 3, 2026
@hbisheng

hbisheng commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-sanitizer-asan

@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, yongman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,yongman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-07-03 03:54:35.233515203 +0000 UTC m=+357216.933894635: ☑️ agreed by yongman.
  • 2026-07-03 04:21:52.361640007 +0000 UTC m=+358854.062019430: ☑️ agreed by JaySon-Huang.

@JaySon-Huang

Copy link
Copy Markdown
Contributor

/cherry-pick release-nextgen-20251011

@ti-chi-bot

Copy link
Copy Markdown
Member

@JaySon-Huang: once the present PR merges, I will cherry-pick it on top of release-nextgen-20251011 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang

Copy link
Copy Markdown
Contributor

/cherry-pick release-nextgen-202603

@ti-chi-bot

Copy link
Copy Markdown
Member

@JaySon-Huang: once the present PR merges, I will cherry-pick it on top of release-nextgen-202603 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hbisheng

hbisheng commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot Bot merged commit c81131a into pingcap:master Jul 3, 2026
11 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

@JaySon-Huang: failed to apply #10948 on top of branch "release-nextgen-20251011":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]
Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

Copy link
Copy Markdown
Member

@JaySon-Huang: new pull request created to branch release-nextgen-202603: #10953.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants