Update perpendicular-flap/solid-solids4foam#872
Draft
MakisH wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In recent solids4foam version (e.g., v2.3), the perpendicular-flap tutorial does not run, as some of the configuration options have changed. Related issue: solids4foam/solids4foam#279
I don't know much about the configuration, but blindly trying different candidates, I got it to work again.
Originally, the case was using the now removed
gradSchemesoptionextendedLeastSquares. I tried withleastSquaresand withleastSquaresS4f, and I am comparing to the old reference results in this figure:There is clearly room for improvement to match the previous state. @philipcardiff @iBatistic what else could I try?
The original case was already not tuned enough to match the other available setups (see the second figure on the tutorial post-processing section). I am not concerned about that at the moment (I mainly don't want to make it work again), but we could give it another try. Bringing CalculiX into the picture (current and archived reference results):
Current setup:
Reference setup: solids4foam v2.0, OpenFOAM v2012, OpenFOAM adapter v1.3.1, CalculiX v2.20, preCICE v3.1.1.
Plotting script and data: solids4foam-debugging.tar.gz
Checklist
changelog-entries/<PRnumber>.md.