Add BranchName WithTrailingAction story#7920
Merged
Merged
Conversation
|
siddharthkp
added
integration-tests: skipped manually
github-actions
Bot
removed
the
update snapshots
siddharthkp
added
the
update snapshots
github-actions
Bot
removed
the
update snapshots
siddharthkp
added
the
update snapshots
github-actions
Bot
removed
the
update snapshots
Demonstrate a trailing action pattern (copy button) for BranchName, serving as a reference for future implementation work. Add WithTrailingActionMenu story with SelectPanel Demonstrates branch switching via SelectPanel anchored to BranchName, showing the 'Change base branch' pattern. Remove overflow:hidden to prevent focus ring clipping
siddharthkp
force-pushed
the
siddharthkp/branchname-trailing-action-story
branch
from
9957e42 to
aad16e8
Compare
siddharthkp
added
the
update snapshots
github-actions
Bot
removed
the
update snapshots
siddharthkp
requested review from
Copilot,
joshblack and
llastflowers
and removed request for
Copilot
joshblack
approved these changes
Jun 11, 2026
joshblack
left a comment
joshblack
left a comment
Member
There was a problem hiding this comment.
Just had one comment for the live region announcements but wanted to approve in advance so you didn't have to wait another day lol
| {/* Screen reader announcement for copy success */} | ||
| {copied && ( | ||
| <VisuallyHidden> | ||
| <Announce>Copied!</Announce> |
Member
There was a problem hiding this comment.
The announcement might be better suited in handleCopy with announce straight from @primer/live-region-element instead of rendering it, in particular if the announcement is hidden. e.g.
import { announce } from '@primer/live-region-element'
const handleCopy = () => {
setCopied(true)
void navigator.clipboard.writeText(branchName)
announce('Copied!');
setTimeout(() => setCopied(false), 2000)
}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new BranchName “feature” stories to document a trailing-action pattern (copy button + optional menu anchor) and extends the BranchName Playwright VRT coverage to include these new stories and focus/menu states.
Changes:
- Added story-only CSS module styles to visually compose BranchName with a trailing IconButton action.
- Added
WithTrailingAction(copy) andWithTrailingActionMenu(SelectPanel anchor) stories underComponents/BranchName/Features. - Extended
e2e/components/BranchName.test.tsto snapshot the new stories and their key focus/menu states.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/BranchName/BranchName.stories.module.css | Adds story-only layout/styling for a trailing-action container and button divider. |
| packages/react/src/BranchName/BranchName.features.stories.tsx | Adds two new feature stories demonstrating copy and menu trailing actions. |
| e2e/components/BranchName.test.ts | Adds VRT coverage for the new stories, including focus states and menu-open state. |
Copilot's findings
- Files reviewed: 3/26 changed files
- Comments generated: 3
Comment on lines
+112
to
+121
| renderAnchor={anchorProps => ( | ||
| <IconButton | ||
| icon={TriangleDownIcon} | ||
| aria-label="Change base branch" | ||
| variant="invisible" | ||
| size="small" | ||
| className={styles.TrailingActionButton} | ||
| {...anchorProps} | ||
| /> | ||
| )} |
Comment on lines
+80
to
+101
| test.describe('With Trailing Action Menu', () => { | ||
| test('focus states @vrt', async ({page}) => { | ||
| await visit(page, { | ||
| id: 'components-branchname-features--with-trailing-action-menu', | ||
| globals: { | ||
| colorScheme: 'light', | ||
| }, | ||
| }) | ||
|
|
||
| // Focus on branch name link | ||
| await page.keyboard.press('Tab') | ||
| await expect(page).toHaveScreenshot('BranchName.With Trailing Action Menu.light.focus-link.png') | ||
|
|
||
| // Focus on trailing action button | ||
| await page.keyboard.press('Tab') | ||
| await expect(page).toHaveScreenshot('BranchName.With Trailing Action Menu.light.focus-button.png') | ||
|
|
||
| // Open the menu | ||
| await page.keyboard.press('Enter') | ||
| await expect(page).toHaveScreenshot('BranchName.With Trailing Action Menu.light.menu-open.png') | ||
| }) | ||
| }) |
Comment on lines
+48
to
+55
| const [copied, setCopied] = React.useState(false) | ||
|
|
||
| const handleCopy = () => { | ||
| setCopied(true) | ||
| void navigator.clipboard.writeText(branchName) | ||
| announce('Copied!') | ||
| setTimeout(() => setCopied(false), 2000) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a feature story demonstrating the trailing action pattern (copy button) for BranchName. This story serves as a reference for the implementation work to upstream this pattern from github-ui's PullRequestBranchName.
The story demonstrates:
Changelog
New
WithTrailingActionstory in BranchName featuresChanged
None
Removed
None
Rollout strategy
Testing & Reviewing
View the story in Storybook: Components > BranchName > Features > With Trailing Action
Merge checklist