Skip to content

fix: update FilteredActionList skeleton to use deterministic widths#7929

Merged
joshblack merged 6 commits into
mainfrom
joshblack/issue-6386-ssr-safe-loaders
Jun 15, 2026
Merged

fix: update FilteredActionList skeleton to use deterministic widths#7929
joshblack merged 6 commits into
mainfrom
joshblack/issue-6386-ssr-safe-loaders

Conversation

@joshblack

@joshblack joshblack commented Jun 5, 2026

Copy link
Copy Markdown
Member

Changelog

New

N/A

Changed

  • FilteredActionList body skeleton rows now use deterministic CSS-module widths instead of render-time randomness, making the loading state SSR-compatible.
  • Kept VRT snapshot updates scoped to FilteredActionList loading states only.
  • Rebased the stacked branch to resolve merge conflicts and keep this PR up to date.

Removed

  • Removed the redundant FilteredActionListBodyLoader test asserting that Math.random is not called.
  • Reverted unrelated VRT snapshot updates for ActionMenu and Avatar.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • npx vitest run packages/react/src/FilteredActionList/FilteredActionList.test.tsx
  • npm run format:diff
  • npm run lint
  • npm run lint:css
  • npm run type-check
  • npm run build
  • npm test -- --run
  • Storybook started successfully and responded for /?path=/story/components-filteredactionlist--default

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6d0f3d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Comment thread packages/react/src/FilteredActionList/FilteredActionList.test.tsx Outdated
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 5, 2026 19:11 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 5, 2026 21:30 Inactive
@joshblack joshblack changed the base branch from main to docs/add-stories-and-snapshots-for-filtered-action-list June 8, 2026 20:16
@joshblack joshblack force-pushed the docs/add-stories-and-snapshots-for-filtered-action-list branch from f2a7f31 to 9c9f6fa Compare June 8, 2026 20:27
@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 30b6ce8 to 31f823b Compare June 8, 2026 20:27
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 8, 2026 20:31 Abandoned
@primer

primer Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 2e12404 to 23c71fb Compare June 8, 2026 20:35
@joshblack joshblack force-pushed the docs/add-stories-and-snapshots-for-filtered-action-list branch from 9c9f6fa to 240df94 Compare June 8, 2026 20:35
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 8, 2026
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 8, 2026 20:39 Abandoned
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 8, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 8, 2026 20:52 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 8, 2026 21:01 Inactive
@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 9640da4 to 3425442 Compare June 9, 2026 15:27
@joshblack joshblack marked this pull request as ready for review June 9, 2026 15:27
Copilot AI review requested due to automatic review settings June 9, 2026 15:27
@joshblack joshblack requested a review from a team as a code owner June 9, 2026 15:27
@joshblack joshblack requested a review from liuliu-dev June 9, 2026 15:27
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 12, 2026 19:35 Abandoned
@joshblack joshblack added the Canary Release Apply this label when you want CI to create a canary release of the current PR label Jun 12, 2026
@primer-integration

primer-integration Bot commented Jun 12, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  CI   Passed
Waiting  VRT   Waiting
Running  Projects   Running

@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 12, 2026 19:47 Inactive
@joshblack joshblack added the integration-tests: skipped manually Changes in this PR do not require an integration test label Jun 12, 2026
@joshblack joshblack force-pushed the docs/add-stories-and-snapshots-for-filtered-action-list branch from 6a59e4f to 16bf968 Compare June 12, 2026 20:35
@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 2f54adc to 49e022a Compare June 12, 2026 20:35
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 12, 2026 20:39 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 12, 2026 20:50 Inactive
@joshblack joshblack added this pull request to the merge queue Jun 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jun 12, 2026
Base automatically changed from docs/add-stories-and-snapshots-for-filtered-action-list to main June 12, 2026 20:58
@joshblack

Copy link
Copy Markdown
Member Author

@copilot fix merge conflicts by rebasing the stack (gh stack rebase)

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@copilot fix merge conflicts by rebasing the stack (gh stack rebase)

Done in f43e61c — I rebased the stack, resolved the conflicts, and pushed the updated branch.

@joshblack

Copy link
Copy Markdown
Member Author

@copilot revert the changes to ActionMenu and Avatar

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@copilot revert the changes to ActionMenu and Avatar

Done in 9708589 — I reverted the ActionMenu and Avatar snapshot changes.

joshblack and others added 6 commits June 15, 2026 12:29
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
@primer primer Bot mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants