Link search results to their package and module#489
Merged
Conversation
Builtin modules such as Prim appear in search results but have no package page; the routeToPackage helper from #424 sent their package badge to the home page. Render the badge as plain text when the result has no package, reuse packageNameRoute from Foundation, and share the badge markup between the module and declaration result arms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #424 by @joprice, whose commit this branch includes: the package and module badges on search results become links to the corresponding package page and module documentation page. Closes #268.
One fix on top of the original PR: builtin modules such as Prim appear in search results but have no package page, and #424 routed their package badge through a fallback to the home page (the
-- this shouldn't happenbranch ofrouteToPackage, which linking the badges made reachable). The package badge is now only rendered as a link when the result actually has a package page; for builtin results it stays plain text. The fixup also reusespackageNameRoutefromFoundationand dedupes the badge markup shared by the module and declaration cases.