Use /MDd flag to compile in debug mode if cargo is in debug mode#167
Open
itsjunetime wants to merge 1 commit into
Open
Use /MDd flag to compile in debug mode if cargo is in debug mode#167itsjunetime wants to merge 1 commit into
itsjunetime wants to merge 1 commit into
Conversation
Contributor
|
I think this is an issue with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
mimalloc_rustis used in conjunction with another msvc library, it needs to set the correct run-time library version (as specified by this microsoft doc). Previously,mimalloc_rustwas always building mimalloc_rust inDynamicReleasemode, which would conflict with other libraries building against msvc who were correctly respecting the debug level (and building inDynamicDebugmode).This issue can be seen in the CI runs of this PR, where mupdf-rs was correctly building in debug mode when cargo was building in debug mode, but the mimalloc DLL was building in release mode still. The linker refused to link the libraries together because of the differing runtime library mode.
As you can see from the later commits on the aforementioned PR, this change fixes the issue. For some reason, using
build.flag_if_supporteddidn't do the trick - I guess the build system isn't aware that/MDdis a valid flag.