Add tzdata to fix ReadTheDocs build and vendor timezone data#2809
Merged
Conversation
Contributor
Author
|
@echedey-ls tests pass, RTD build succeeds |
cwhanse
approved these changes
Jul 6, 2026
echedey-ls
reviewed
Jul 7, 2026
|
|
||
| Bug fixes | ||
| ~~~~~~~~~ | ||
| * Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`) |
Member
There was a problem hiding this comment.
Suggested change
| * Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`) | |
| * Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`, :pull:`2809`) |
I don't consider this to be a user-facing bugfix, so I rather have one entry in enhancements (like "ensure all timezones are available in all OSes") and another one in maintenance (e.g. "fix documentation builds on runner images lacking link-type timezones"
| 'requests', | ||
| 'scipy >= 1.7.2', | ||
| 'h5py', | ||
| 'tzdata', |
Member
There was a problem hiding this comment.
Suggested change
| 'tzdata', | |
| 'tzdata', # ensure all timezones are available in all installs for consistency GH#2795 |
Member
|
Thanks @yonryzhu and @echedey-ls |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.