gh-145855: Remove the DELETE_ATTR bytecode#146216
Merged
Merged
Conversation
aisk
requested review from
ericsnowcurrently,
iritkatriel and
markshannon
as code owners
aisk
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
|
This PR is stale because it has been open for 30 days with no activity. |
markshannon
reviewed
Jun 30, 2026
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
This looks good.
Can you fix the merge conflicts, so I can merge it?
# Conflicts: # Doc/tools/removed-ids.txt # Include/internal/pycore_magic_number.h # Include/internal/pycore_uop_ids.h # Modules/_testinternalcapi/test_cases.c.h # Programs/test_frozenmain.h # Python/executor_cases.c.h # Python/generated_cases.c.h
Documentation build overview
22 files changed ·
|
Member
Author
|
@markshannon Thank you for your review, updated with the current main branch. |
Member
|
Sorry, more merge conflicts from merging #146006 |
# Conflicts: # Include/internal/pycore_magic_number.h # Include/internal/pycore_opcode_metadata.h # Include/internal/pycore_uop_ids.h # Include/opcode_ids.h # Lib/_opcode_metadata.py # Modules/_testinternalcapi/test_targets.h # Programs/test_frozenmain.h # Python/opcode_targets.h
github-actions
Bot
removed
the
stale
markshannon
approved these changes
Jul 6, 2026
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Looks good. I do like improvements with net negative LOC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE_ATTRtoPUSH_NULL; STORE_ATTR;STORE_ATTR_*if value isnull.DELETE_ATTRbytecode instruction #145855📚 Documentation preview 📚: https://cpython-previews--146216.org.readthedocs.build/