Harden ValueReader (backport #2007)#2008
Merged
Merged
Conversation
readBytes trusted the length prefix from the wire and allocated a buffer of that size before confirming the stream actually contained that many bytes. It now checks the declared length against what is available and throws MalformedFrameException otherwise. Add ValueReaderTest with coverage for long strings and field values. (cherry picked from commit 6a87a8d)
readTable and readArray recursed into readFieldValue without any bound on how deeply tables and arrays could nest inside each other. Add a maximum nesting depth, throwing MalformedFrameException once it is exceeded. The limit is 32 levels of nesting. Add ValueReaderTest with coverage for nested tables and arrays, and for reading byte vectors whose declared length exceeds available data. (cherry picked from commit 09af76f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2007 done by [Mergify](https://mergify.com).