feat: use optimized pro guard file#223
Merged
cortinico merged 1 commit intoJun 5, 2026
Merged
Conversation
ee33bb0 to
8b4aa92
Compare
Contributor
Author
|
cc: @cortinico |
cortinico
approved these changes
Jun 5, 2026
Member
cortinico
left a comment
There was a problem hiding this comment.
Can we apply also the same change to RNTester? Also do we expect potential crashes for the users with this one?
Contributor
Author
I believe you already did that a few months back as part of - facebook/react-native#54143
I expect not. I tested this change and AGP9 enabled with opt outs on a RN App with following packages and no crash concerning pro-guard: "@react-native-async-storage/async-storage": "^3.1.0",
"@react-native/new-app-screen": "0.85.3",
"@react-navigation/native-stack": "^7.15.1",
"@shopify/react-native-skia": "^2.6.3",
"react-native-mmkv": "^4.3.1",
"react-native-nitro-image": "^0.14.0",
"react-native-nitro-modules": "^0.35.7",
"react-native-pager-view": "^8.0.2",
"react-native-reanimated": "^4.3.1",
"react-native-safe-area-context": "^5.7.0",
"react-native-screens": "^4.25.2",
"react-native-share": "^12.3.1",
"react-native-svg": "^15.15.5",
"react-native-vision-camera": "^5.0.10",
"react-native-worklets": "^0.8.3" |
Member
Ah yeah 😅 thanks for pointing thaat out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is part of Android Gradle Plugin v9 adoption. With this PR, we:
Upgrade theGradleversion to v9.4.1Both of the above are required for AGP v9 and are harmless with the current AGP v8, so we can ship it as a ground work for AGP v9.
Changelog:
[ANDROID] [CHANGED] - Use optimized proguard file
Test Plan:
template.mp4