Skip to content

feat: use optimized pro guard file#223

Merged
cortinico merged 1 commit into
react-native-community:mainfrom
hurali97:agp9/bump-gradle-and-optimized-proguard
Jun 5, 2026
Merged

feat: use optimized pro guard file#223
cortinico merged 1 commit into
react-native-community:mainfrom
hurali97:agp9/bump-gradle-and-optimized-proguard

Conversation

@hurali97
Copy link
Copy Markdown
Contributor

@hurali97 hurali97 commented Jun 2, 2026

Summary:

This PR is part of Android Gradle Plugin v9 adoption. With this PR, we:

  • Upgrade the Gradle version to v9.4.1
  • Use the optimized proguard file

Both of the above are required for AGP v9 and are harmless with the current AGP v8, so we can ship it as a ground work for AGP v9.

Changelog:

[ANDROID] [CHANGED] - Use optimized proguard file

Test Plan:

  • CI passes
  • Template App builds successfully
template.mp4

@hurali97 hurali97 changed the title Agp9/bump gradle and optimized proguard feat: Upgrade Gradle to v9.4.1 and use optimized pro guard file Jun 3, 2026
@hurali97 hurali97 marked this pull request as ready for review June 3, 2026 11:16
@hurali97 hurali97 force-pushed the agp9/bump-gradle-and-optimized-proguard branch from ee33bb0 to 8b4aa92 Compare June 5, 2026 06:18
@hurali97 hurali97 changed the title feat: Upgrade Gradle to v9.4.1 and use optimized pro guard file feat: use optimized pro guard file Jun 5, 2026
@hurali97
Copy link
Copy Markdown
Contributor Author

hurali97 commented Jun 5, 2026

cc: @cortinico

Copy link
Copy Markdown
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply also the same change to RNTester? Also do we expect potential crashes for the users with this one?

@hurali97
Copy link
Copy Markdown
Contributor Author

hurali97 commented Jun 5, 2026

Can we apply also the same change to RNTester?

I believe you already did that a few months back as part of - facebook/react-native#54143

Also do we expect potential crashes for the users with this one?

I expect not. I tested this change and AGP9 enabled with opt outs on a RN App with following packages and no crash concerning pro-guard:

    "@react-native-async-storage/async-storage": "^3.1.0",
    "@react-native/new-app-screen": "0.85.3",
    "@react-navigation/native-stack": "^7.15.1",
    "@shopify/react-native-skia": "^2.6.3",
    "react-native-mmkv": "^4.3.1",
    "react-native-nitro-image": "^0.14.0",
    "react-native-nitro-modules": "^0.35.7",
    "react-native-pager-view": "^8.0.2",
    "react-native-reanimated": "^4.3.1",
    "react-native-safe-area-context": "^5.7.0",
    "react-native-screens": "^4.25.2",
    "react-native-share": "^12.3.1",
    "react-native-svg": "^15.15.5",
    "react-native-vision-camera": "^5.0.10",
    "react-native-worklets": "^0.8.3"

@cortinico cortinico merged commit a34bd7e into react-native-community:main Jun 5, 2026
1 check passed
@cortinico
Copy link
Copy Markdown
Member

I believe you already did that a few months back as part of - facebook/react-native#54143

Ah yeah 😅 thanks for pointing thaat out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants