fix: yoga crash with display:none#1976
Open
javache wants to merge 1 commit into
Open
Conversation
Summary: It fixes this issue: react/react-native#52349 Basically, in some rare cases, having an element with `display:none` style caused the app to crash. It was caused by a stale `hasNewLayout` flag on the hidden view That flag was always set in `computeFlexBasisForChildren` for elements with `display:none` style, but could be never consumed/reset, because of a cache hit or something. Since such elements contribute nothing to the layout sizes, I made the change to actually touch them only during actual layout passes ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - Crash: YogaLayoutableShadowNode.cpp: function layout: assertion failed (YGNodeGetOwner(childYogaNode) == &yogaNode_) react/react-native#52349 X-link: react/react-native#57197 Reviewed By: christophpurrer Differential Revision: D108796888 Pulled By: javache
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108796888. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It fixes this issue: react/react-native#52349
Basically, in some rare cases, having an element with
display:nonestyle caused the app to crash.It was caused by a stale
hasNewLayoutflag on the hidden viewThat flag was always set in
computeFlexBasisForChildrenfor elements withdisplay:nonestyle, but could be never consumed/reset, because of a cache hit or something.Since such elements contribute nothing to the layout sizes, I made the change to actually touch them only during actual layout passes
Changelog:
[GENERAL] [FIXED] - Crash: YogaLayoutableShadowNode.cpp: function layout: assertion failed (YGNodeGetOwner(childYogaNode) == &yogaNode_) react/react-native#52349
X-link: react/react-native#57197
Reviewed By: christophpurrer
Differential Revision: D108796888
Pulled By: javache