changes made in the navbar for docs section#1887
Conversation
|
@Tannuu18 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1886:
|
|
heyy @sanjay-kv can you please review this Pull request and merge it by today??? Need it for Gssoc streak. |
There was a problem hiding this comment.
Pull request overview
This PR updates global site CSS to prevent the Docs sidebar from obscuring or pushing the top navbar, aiming to keep the Docs navigation fully visible (fixing #1886).
Changes:
- Adds new navbar stacking/positioning overrides intended to keep the navbar above the Docs sidebar.
- Removes/adjusts transforms and other layout-related CSS that can create stacking-context clipping.
- Applies a number of CSS formatting/selector-spacing cleanups and removes some older z-index overrides.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iitzIrFan
left a comment
There was a problem hiding this comment.
resolve comments from co-pilot!
|
✅ Synchronized metadata from Issue #1886:
|
|
heyy @iitzIrFan i have implemented the changes that co-pilot suggested. Kindly review it. |
Adez017
left a comment
There was a problem hiding this comment.
@Tannuu18 too many changes are been made over here and i think this should needed a triage .
CC: @sanjay-kv @iitzIrFan
| } | ||
|
|
||
| /* Stronger layout rules to keep labels and icons aligned across deployments */ | ||
| .dropdown__menu .grid>.border-r.col-span-1, | ||
| .dropdown-content .grid>.border-r.col-span-1 { | ||
| display: flex !important; | ||
| align-items: center !important; | ||
| justify-content: flex-start !important; | ||
| flex: 0 0 auto !important; | ||
| min-width: auto !important; | ||
| /* allow label to size to content */ | ||
| padding-right: 0.4rem !important; | ||
| } | ||
|
|
||
| /* Make the label itself use a single line and center vertically */ | ||
| .dropdown__menu .grid>.border-r.col-span-1 a, | ||
| .dropdown-content .grid>.border-r.col-span-1 a { |
There was a problem hiding this comment.
not sure do we need this much amount of cosmic changes over here @sanjay-kv @iitzIrFan we had many elements depends on this css file and unwanted chnages can disrupt other functionality
|
|
||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary { | ||
| --ifm-alert-foreground-color: #ffffff !important; | ||
| --ifm-alert-background-color: #0f172a !important; | ||
| --ifm-alert-background-color-highlight: rgba(148, 163, 184, 0.14) !important; | ||
| --ifm-alert-border-color: #2563eb !important; | ||
| --ifm-link-color: #93c5fd !important; | ||
| --ifm-link-hover-color: #bfdbfe !important; | ||
| background-color: var(--ifm-alert-background-color) !important; | ||
| background: var(--ifm-alert-background-color) !important; | ||
| border-left-color: var(--ifm-alert-border-color) !important; | ||
| color: #ffffff !important; | ||
| } | ||
|
|
||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"], | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"], | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"], | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"], | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] p, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] li, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] span, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] strong, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] em, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] code, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-info [class*="admonitionContent_"] a, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] p, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] li, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] span, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] strong, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] em, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] code, | ||
| html[data-theme="dark"].blog-post-page .markdown .theme-admonition-note [class*="admonitionContent_"] a, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] p, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] li, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] span, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] strong, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] em, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] code, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--info [class*="admonitionContent_"] a, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] p, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] li, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] span, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] strong, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] em, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] code, | ||
| html[data-theme="dark"].blog-post-page .markdown .alert--secondary [class*="admonitionContent_"] a { | ||
| color: #ffffff !important; | ||
| -webkit-text-fill-color: #ffffff !important; |
There was a problem hiding this comment.
same things go for this one too @sanjay-kv @iitzIrFan
|
|
||
| .pagination-btn.disabled { | ||
| opacity: 0.4 !important; | ||
| cursor: not-allowed !important; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Unwanted css removal for the leadeerboard pagination . I dont think this is required over here related to this issue
Description
Updated the docs layout CSS so the top navigation remains fully visible and no longer gets pushed or clipped by the docs sidebar on docs.
Fixes #1886
Type of Change
Changes Made
Added a sticky, full-width header/navbar override in [custom.css]
Ensured header, [.theme-doc-navbar], and [.navbar] stay above the docs sidebar using a high [z-index]
Removed transform/clipping on .navbar__inner and .navbar__items to prevent stacking/context overlap issues
This prevents the sidebar from pushing the top nav items to the right or obscuring elements like Showcase
Dependencies
none
Checklist
npm run buildand attached screenshot(s) in this PR.