Skip to content

chore(fab): remove fab completely from codebase#3348

Merged
hopehadfield merged 3 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin
Jun 16, 2026
Merged

chore(fab): remove fab completely from codebase#3348
hopehadfield merged 3 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin

Conversation

@ciiay

@ciiay ciiay commented Jun 10, 2026

Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

For RHIDP-13680

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ CODEOWNERS Validation Failed

The following users are listed in CODEOWNERS but are not members of the rhdh-plugins-codeowners team:

rrbanda

An org admin needs to add the missing members to the team before this PR can be merged.

@christoph-jerolimov

Copy link
Copy Markdown
Member

Hi @ciiay, we like to follow https://github.com/backstage/community-plugins/blob/87b63379d186f1b0b2c8a9c2158169c9357f89a6/docs/plugin-maintainers-guide.md#archiving-a-plugin

But we don't want deprecate the npm package now. But can you add the essential information about the last release to this two files:

  1. https://github.com/redhat-developer/rhdh-plugins/blob/main/ARCHIVED_WORKSPACES.md
  2. https://github.com/redhat-developer/rhdh-plugins/blob/main/.github/archived-plugins.json

@hopehadfield

Copy link
Copy Markdown
Member

@christoph-jerolimov if the workspace is added to https://github.com/redhat-developer/rhdh-plugins/blob/main/.github/archived-plugins.json, it will trigger the GitHub Action to automatically deprecate on npm, so we should hold off on doing this.

Perhaps we open a separate JIRA as a reminder to add the plugin to the list once we are ready for deprecation.

@hopehadfield hopehadfield left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving so that it can be merged once the merge conflicts are resolved and the plugin is added to https://github.com/redhat-developer/rhdh-plugins/blob/main/ARCHIVED_WORKSPACES.md 🙂

For future reference, there is a script that automates the archive process for you (see https://github.com/redhat-developer/rhdh-plugins/blob/main/CONTRIBUTING.md#archiving-a-plugin-or-workspace).

@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin branch from bb4cd38 to d45e363 Compare June 15, 2026 01:49
ciiay added 2 commits June 16, 2026 09:26
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin branch from f63bb16 to fd13eb6 Compare June 16, 2026 13:27
@hopehadfield hopehadfield enabled auto-merge (squash) June 16, 2026 14:34
@sonarqubecloud

Copy link
Copy Markdown

@hopehadfield hopehadfield merged commit 36123e3 into redhat-developer:main Jun 16, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants