Skip to content

fix(lightspeed): improve chat history sidebar UI and delete modal styling#3366

Merged
its-mitesh-kumar merged 7 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/lightspeed-sidebar-ui-improvements
Jun 12, 2026
Merged

fix(lightspeed): improve chat history sidebar UI and delete modal styling#3366
its-mitesh-kumar merged 7 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/lightspeed-sidebar-ui-improvements

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

  1. Add icons to the chat action menu (Rename, Pin/Unpin, Delete)

  2. Fix sidebar icon alignment

    • Drawer Collapse Icon and sort icon on same vertical line
    • New Chat Button and Drawer Collapse Icon on same horizontal line
    • New Chat, Search Box, Pinned Chat, Chat on same vertical line.
  3. Improve the delete confirmation modal with rounded styling and chat name in the title (100 characters), removed from your Lightspeed Activity from description.

  4. Keep the "New Chat" button always visible but disabled when a new chat is open

  5. Update empty state messages for pinned and recent chats, updated the styles.

Fixed

UI after Fix

Light Theme

S_.2026-06-11.at.7.20.38.AM.mov

Dark Theme

S_.2026-06-11.at.7.26.04.AM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app

rhdh-gh-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v2.9.1

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.01%. Comparing base (df49416) to head (4ce8fd2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   54.01%   54.01%   -0.01%     
==========================================
  Files        2409     2409              
  Lines       87709    87702       -7     
  Branches    24285    24284       -1     
==========================================
- Hits        47377    47370       -7     
  Misses      40025    40025              
  Partials      307      307              
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from df49416
ai-integrations 70.03% <ø> (ø) Carriedforward from df49416
app-defaults 69.60% <ø> (ø) Carriedforward from df49416
augment 46.39% <ø> (ø) Carriedforward from df49416
bulk-import 72.69% <ø> (ø) Carriedforward from df49416
cost-management 17.48% <ø> (ø) Carriedforward from df49416
dcm 60.27% <ø> (ø) Carriedforward from df49416
extensions 62.17% <ø> (ø) Carriedforward from df49416
global-floating-action-button 74.30% <ø> (ø) Carriedforward from df49416
global-header 61.63% <ø> (ø) Carriedforward from df49416
homepage 52.60% <ø> (ø) Carriedforward from df49416
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from df49416
konflux 91.01% <ø> (ø) Carriedforward from df49416
lightspeed 68.45% <100.00%> (-0.04%) ⬇️
mcp-integrations 85.46% <ø> (ø) Carriedforward from df49416
orchestrator 37.33% <ø> (ø) Carriedforward from df49416
quickstart 62.09% <ø> (ø) Carriedforward from df49416
sandbox 79.56% <ø> (ø) Carriedforward from df49416
scorecard 83.93% <ø> (ø) Carriedforward from df49416
theme 64.54% <ø> (ø) Carriedforward from df49416
translations 8.49% <ø> (ø) Carriedforward from df49416
x2a 78.79% <ø> (ø) Carriedforward from df49416

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df49416...4ce8fd2. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

@HusneShabbir HusneShabbir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use the same pin icon across the UI for consistency?

Image

@ShiranHi

Copy link
Copy Markdown

@its-mitesh-kumar thanks for these great improvements!
I have a few quick comments and questions:

  1. Can we reduce the left padding in each section of the chat history panel to align it better with the prototype?
image01
  1. Delete Button Color: In delete mode, the dark theme red button color looks like it might not be aligned with [PatternFly standards]
image05

A couple of other notes (not sure if they belong in this specific ticket):

  1. Can we align the pencil icon inside the "New chat" button?
image03
  1. The chat text field shouldn't have a background
image04

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

1.Can we reduce the left padding in each section of the chat history panel to align it better with the prototype?

@ShiranHi We already have a bug for it https://redhat.atlassian.net/browse/RHDHBUGS-3247.

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

@ShiranHi addressed your 2nd comment. I am attaching the screen recording.

S_.2026-06-11.at.2.45.48.PM.mov

@karthikjeeyar karthikjeeyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @HusneShabbir there are two different icons in the play.

Pin/Unpin menu items: ThumbtackIcon from @patternfly/react-icons
Pinned chat sidebar indicator: PushPinIcon from @mui/icons-material

Use PF icons everywhere for consistency and avoid mix matching multiple frameworks as much as possible.

Comment thread workspaces/lightspeed/plugins/lightspeed/src/components/DeleteModal.tsx Outdated
Comment thread workspaces/lightspeed/plugins/lightspeed/src/components/DeleteModal.tsx Outdated
Comment thread workspaces/lightspeed/plugins/lightspeed/src/components/LightSpeedChat.tsx Outdated
Comment thread workspaces/lightspeed/plugins/lightspeed/src/components/CollapsedHistoryStrip.tsx Outdated
@karthikjeeyar

Copy link
Copy Markdown
Member

/approve
/lgtm

@HusneShabbir HusneShabbir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@its-mitesh-kumar its-mitesh-kumar enabled auto-merge (squash) June 12, 2026 07:38
its-mitesh-kumar and others added 7 commits June 12, 2026 13:18
…ling

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
…tion

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rohitkrai03 rohitkrai03 force-pushed the fix/lightspeed-sidebar-ui-improvements branch from 4dc283a to 4ce8fd2 Compare June 12, 2026 07:48
@sonarqubecloud

Copy link
Copy Markdown

@openshift-ci openshift-ci Bot removed the lgtm label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@its-mitesh-kumar its-mitesh-kumar merged commit 68be3de into redhat-developer:main Jun 12, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants