fix(lightspeed): minor UI fix#3627
Conversation
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Changed Packages
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
==========================================
- Coverage 54.01% 54.01% -0.01%
==========================================
Files 2325 2325
Lines 89151 89154 +3
Branches 24962 24966 +4
==========================================
- Hits 48156 48155 -1
- Misses 40806 40810 +4
Partials 189 189
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Sad to see 😢 its happening for more icon. Firstly I observed for main icon on notebook. |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 7:14 PM UTC · Completed 7:20 PM UTC |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
its-mitesh-kumar
left a comment
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
@ciiay We have fix similar issues at other places too, For me it seems to be something off from PF upstream. I will be raising upstream issue for it. Since the impact is not that big. I will like to hold this PR to get in. Let me know your thoughts.
its-mitesh-kumar
left a comment
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
Root Cause & Upstream Fix
@patternfly/react-core@6.6.0 fixes the MenuToggle duplicate caret. See patternfly/patternfly-react#12368.
How it was fixed:
Before (6.4.3):
MenuToggle.tsxusesCaretDownIcon
→CaretDownIcongoes throughcreateIconBase
→createIconBaserenders TWO nested SVGs (default + rh-ui)
→ No CSS to hide the rh-ui one (base-no-reset.cssdoesn't include it)
→ Both SVGs visible = duplicate caret
After (6.6.0, via #12368):
MenuToggle.tsxusesRhUiCaretDownIcon(direct import)
→RhUiCaretDownIconis a direct single-SVG icon
→ Does NOT go throughcreateIconBase's dual-rendering path
→ One SVG rendered = no duplicate
Broader Icon Migration
PF is migrating all legacy FA icons to direct RH brand icons, which will fix the other dual-icon issues we've been working around with display: none hacks. Tracking issues:
- #12402 — Navigation, action & status icons (27 icons including
AngleDownIcon,PlusIcon,SearchIcon,TrashIcon,ExpandIcon, etc.) — OPEN - #12401 — Layout, brand & misc icons (28 icons including
EllipsisVIcon,SortAmountDownIcon, etc.) — OPEN - #12399 — Infrastructure & file icons (23 icons) — OPEN
Once these are completed and released, the display: none overrides for .pf-v6-icon-rh-ui in LightSpeedChat.tsx and UploadResourceScreen.tsx can be removed. In the meantime, a single global CSS rule (.pf-v6-icon-rh-ui { display: none }) would be a cleaner alternative to per-component hacks.
3 participants
Hey, I just made a Pull Request!
Fix duplicate caret icons in the message bar model selector dropdown.
✔️ Checklist
Before:
After:
