Skip to content

Refactor reply descriptions - multiple aggregators#3533

Merged
dwdougherty merged 4 commits into
mainfrom
LiorKogan-patch-1
Jun 22, 2026
Merged

Refactor reply descriptions - multiple aggregators#3533
dwdougherty merged 4 commits into
mainfrom
LiorKogan-patch-1

Conversation

@LiorKogan

Copy link
Copy Markdown
Member

No description provided.

@LiorKogan LiorKogan requested a review from dwdougherty June 22, 2026 07:29
@CLAassistant

CLAassistant commented Jun 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jit-ci

jit-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@LiorKogan

LiorKogan commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Note: once approved, it should be applied to TS.REVRANGE, TS.MRANGE, TS.MREVRANGE as well.

@dwdougherty dwdougherty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @LiorKogan; LGTM.

@dwdougherty

dwdougherty commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Hi @LiorKogan. I took a shot at updating the other 3 commands. Will you please take a look?

Also, please sign the CLA; otherwise, I can't merge this PR.

Clarify the array reply format for timestamp-value pairs in the documentation.
Clarify array reply structure for reverse range results.
@LiorKogan

Copy link
Copy Markdown
Member Author

Thank you.
I applied the same changes also in ts.mrange lines 583-587 and similarly in ts.mrevrange.

@LiorKogan LiorKogan requested a review from dwdougherty June 22, 2026 18:54
@dwdougherty

Copy link
Copy Markdown
Collaborator

Thanks again, @LiorKogan. I wasn't 100% sure what else needed to be changed.

@dwdougherty dwdougherty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll go ahead and merge.

@dwdougherty dwdougherty merged commit 86f9c26 into main Jun 22, 2026
74 checks passed
@dwdougherty dwdougherty deleted the LiorKogan-patch-1 branch June 22, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants