Preserve multiline job logs#592
Merged
Merged
Conversation
Job attempt logs can contain newline-delimited records, but the UI rendered them through a shared panel that treated all content as ordinary inline code. That collapsed multiline log output into a single visual paragraph and made the same component responsible for both copyable panel chrome and plaintext semantics. Split the reusable copy button shell into a copyable panel and make the plaintext panel string-only. Job logs and wait expressions now render through `pre`/`code` markup with explicit whitespace behavior, while the JSON viewer keeps its structured interactive React tree outside preformatted code markup. Focused component coverage now asserts multiline plaintext markup, exact clipboard text, and the JSON viewer's non-preformatted structure. Storybook also covers multiline logs and wrapped expressions so the two plaintext layouts are visible.
bgentry
force-pushed
the
bg/fix-preformatted-log-panel
branch
from
49e1de8 to
4587c1c
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brandur
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job attempt logs can contain newline-delimited records, but the UI rendered them through the same shared panel used by structured JSON content. The plain code markup collapsed log line breaks, while wrapping the shared component in
pre/codewould put JSONView's interactive disclosure markup inside preformatted code.This splits the copyable panel chrome from plaintext semantics. Job logs and wait expressions now use a string-only plaintext panel with explicit preformatted whitespace behavior, while JSONView uses the copyable shell directly and keeps its structured React tree outside preformatted markup. Storybook now includes multiline log and wrapped-expression examples so those layouts are easier to inspect.
This builds on the issue identified in #530, but takes a narrower approach so the log viewer and JSON viewer keep their distinct rendering behavior.
Closes #530.