Adopt to LLVM 23 CfiFunctionIndex change#157476
Open
zmodem wants to merge 1 commit into
Open
Conversation
llvm/llvm-project#201635 removed symbols()
rustbot
added
A-LLVM
Collaborator
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@mtrofin does this look right to you? I don't really know this code, but based it on the diff to llvm/lib/LTO/LTO.cpp in your change. |
Contributor
Author
|
@rustbot label: +llvm-main |
rustbot
added
the
llvm-main
mtrofin
approved these changes
Jun 5, 2026
Yes - not sure about the version-based check, I'm assuming that's related to how rust takes dependency on LLVM. But the rest lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#201635 removed symbols()