crater: reserve only keyword#157487
Draft
CrooseGit wants to merge 2 commits into
Draft
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Apologies for ping, my mistake. |
Contributor
|
Rust has never added a non-contextual keyword without an edition (yet). |
This comment was marked as outdated.
This comment was marked as outdated.
21061b3 to
d4323d1
Compare
Member
|
Indeed, and it never will. We want to see what the migration would look like, if it'd require half the ecosystem to use |
d4323d1 to
0463146
Compare
Member
|
(once |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 5, 2026
crater: reserve `only` keyword
Contributor
|
💔 Test for ea16527 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
onlykeyword + removes existing instances ofonly.Opening as draft for a crater run: t-lang wants to have
onlybounds and we want to see how bad things would break if we had it as a keyword.The same kind of breakage at this position would also apply for the
maybebounds, the possible way forward for specialization, which we may also check in this PR.