You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add or tighten focused edge-case tests or type assertions in mod_test.go, evmrpc/test.go related to CI, Docker, Kubernetes, build tooling, release automation; avoid docs-only changes and broad refactors.
Keep the change narrow so it is straightforward to review.
Notes:
I kept this scoped to the relevant implementation and tests.
Low Risk
Test-only change to mod_test.go; no runtime or dependency behavior is modified.
Overview
Adds TestIsBannedModule, a table-driven unit test for the existing isBannedModule helper used by the go.mod / go.sum banned-dependency checks.
It covers exact upstream paths, major-version suffixes (e.g. ibc-go/v6), prefix-only paths that must not be banned (e.g. tm-db), empty input, and unrelated modules—locking in the intended matching behavior without changing production code.
Reviewed by Cursor Bugbot for commit 244866d. Bugbot is set up for automated code reviews on this repo. Configure here.
We truly appreciate your contribution and the time you’ve invested in this PR.
Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective.
If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.
This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in.
Please feel free to reopen it whenever you’re ready to pick it back up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Notes: