Skip to content

Plex 2773#2122

Closed
silaslenihan wants to merge 1 commit into
feature/solcap-read_triggerfrom
PLEX-2773
Closed

Plex 2773#2122
silaslenihan wants to merge 1 commit into
feature/solcap-read_triggerfrom
PLEX-2773

Conversation

@silaslenihan

Copy link
Copy Markdown
Contributor

Requires

Supports

@silaslenihan silaslenihan requested review from a team as code owners June 3, 2026 18:12
@silaslenihan silaslenihan marked this pull request as draft June 3, 2026 18:12
@silaslenihan silaslenihan changed the base branch from main to feature/solcap-read_trigger June 3, 2026 18:13
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👋 silaslenihan, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (6)

pkg/types.(*UnimplementedSolanaService) (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types.SolanaService (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types/mocks.(*SolanaService) (1)
  • QueryTrackedLogs — Type changed:
func(
  context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string
)
([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, error)
pkg/types/mocks.(*SolanaService_Expecter) (1)
  • QueryTrackedLogs — Type changed:
func(
  interface{}, 
  interface{}, 
  + interface{}, 
  interface{}
)
*SolanaService_QueryTrackedLogs_Call
pkg/types/mocks.(*SolanaService_QueryTrackedLogs_Call) (2)
  • Run — Type changed:
func(
  func(ctx context.Context, 
  filterQuery []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  - limitAndSort github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort)
  + limitAndSort github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + filterName string)
)
*SolanaService_QueryTrackedLogs_Call
  • RunAndReturn — Type changed:
func(
  func(context.Context, 
  []github.com/smartcontractkit/chainlink-common/pkg/types/query.Expression, 
  - github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, 
  + github.com/smartcontractkit/chainlink-common/pkg/types/query.LimitAndSort, 
  + string) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/solana.Log, 
  error)
)
*SolanaService_QueryTrackedLogs_Call

✅ Compatible Changes (4)

pkg/capabilities/v2/chain-capabilities/solana.(*FilterLogTriggerRequest) (1)
  • GetIncludeReverted — ➕ Added
pkg/capabilities/v2/chain-capabilities/solana.FilterLogTriggerRequest (1)
  • IncludeReverted — ➕ Added
pkg/chains/solana.(*QueryTrackedLogsRequest) (1)
  • GetFilterName — ➕ Added
pkg/chains/solana.QueryTrackedLogsRequest (1)
  • FilterName — ➕ Added

📄 View full apidiff report

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jul 4, 2026
@bolekk

bolekk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@silaslenihan can we close this now? it's pinging people via the DX bot

@silaslenihan

Copy link
Copy Markdown
Contributor Author

@silaslenihan can we close this now? it's pinging people via the DX bot

Yeah, this one got de-prioritized. I'll close it can always reopen later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants