[CRE-4317] Implement genericless adapter for ocr3types.OnchainKeyring2#2137
Merged
Conversation
✅ API Diff Results -
|
pavel-raykov
requested review from
kaleofduty
and removed request for
cedric-cordenier
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a small helper in the keystore module to bridge between a non-generic (“genericless”) OCR3 onchain keyring interface and libocr’s generic ocr3types.OnchainKeyring2[RI], along with a libocr dependency bump to a version that includes the required OCR3 types.
Changes:
- Added
OnchainKeyring2GenericlessandOnchainKeyring2ToGenericAdapter[RI]to adapt implementations that don’t care about theRIgeneric parameter. - Updated
github.com/smartcontractkit/libocrdependency version (and correspondinggo.sumentries).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| keystore/ocr3/utils.go | Introduces the genericless keyring interface and adapter to ocr3types.OnchainKeyring2[RI]. |
| keystore/go.mod | Bumps github.com/smartcontractkit/libocr to a newer pseudo-version needed for OCR3 keyring types. |
| keystore/go.sum | Updates checksums to match the new libocr version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmank88
reviewed
Jun 9, 2026
jmank88
reviewed
Jun 9, 2026
jmank88
reviewed
Jun 9, 2026
jmank88
reviewed
Jun 9, 2026
jmank88
previously approved these changes
Jun 9, 2026
kaleofduty
reviewed
Jun 23, 2026
kaleofduty
approved these changes
Jun 23, 2026
george-dorin
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports smartcontractkit/chainlink-evm#469