Skip to content

fix: allow .jsx entry-server#2090

Merged
birkskyum merged 8 commits into
solidjs:mainfrom
huseeiin:allow-js-entry
Jul 16, 2026
Merged

fix: allow .jsx entry-server#2090
birkskyum merged 8 commits into
solidjs:mainfrom
huseeiin:allow-js-entry

Conversation

@huseeiin

Copy link
Copy Markdown
Contributor

allow using .jsx extension instead of hardcoding .tsx

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

@changeset-bot

changeset-bot Bot commented Feb 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c77c415

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Feb 27, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit c77c415
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a594b433309d200087b0bf3
😎 Deploy Preview https://deploy-preview-2090--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Feb 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2090
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2090

commit: c77c415

@huseeiin
huseeiin marked this pull request as draft February 27, 2026 09:43
@huseeiin
huseeiin marked this pull request as ready for review February 27, 2026 09:49
@huseeiin
huseeiin marked this pull request as draft February 27, 2026 09:53
@huseeiin
huseeiin marked this pull request as ready for review February 27, 2026 09:56
@karimmaassen

Copy link
Copy Markdown

This most likely fixes #2095

@lxsmnsyc lxsmnsyc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the global declaration (not sure yet what's a decent workaround), this lgtm

@birkskyum
birkskyum merged commit d2f0621 into solidjs:main Jul 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants