Change how we test DnsOverHttps#9549
Open
swankjesse wants to merge 2 commits into
Open
Conversation
Rather than returning opaque hard-coded response bodies, use our new message encoder so we can test with real value objects.
swankjesse
commented
Jul 15, 2026
| @@ -79,75 +85,68 @@ class DnsOverHttpsTest { | |||
|
|
|||
| @Test | |||
| fun getOne() { | |||
Collaborator
Author
There was a problem hiding this comment.
The previous opaque hex values made it difficult to tell that the query was for google.com and the result was for star.c10r.facebook.com.
In a forthcoming PR I’ll replace both with lysine.dev
Collaborator
Author
There was a problem hiding this comment.
(It was a bug that the query and result domain names didn’t match)
| @RequiresOptIn(level = ERROR, message = "Internal APIs for OkHttp's own modules") | ||
| @Retention(BINARY) | ||
| @Target(CLASS, FUNCTION, PROPERTY) | ||
| annotation class OkHttpInternalApi |
Collaborator
Author
There was a problem hiding this comment.
Keen to hear feedback on this thing I’m sneaking in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than returning opaque hard-coded response bodies, use our new message encoder so we can test with real value objects.