feat(unic-archon-dlc): add /improve-architecture skill (redesign step 10)#270
Merged
Merged
Conversation
… 10) Split the off-line arch-health half out of the inert legacy unic-dlc-cleanup workflow into an interactive command/skill (two-axis, ADR-0017): its core is a design grilling loop that needs the live conversation, so it composes Matt Pocock's improve-codebase-architecture verbatim (+ /codebase-design, /grilling, /domain-modeling) rather than reimplementing it. Why it earns its place (ADR-0021): it adds three DLC layers the raw skill lacks — an intent-drift pass (PRD stories/ACs vs shipped), a durable arch-review.md artifact under <artifacts_dir>/ (ADR-0015), and an ADR-consolidation gate with superseding across both ADR homes (plugin-local + repo-root; never deletes an ADR, updates the matching README.md index). Two modes: `/improve-architecture <slug>` is intent-grounded against a build session; no-arg is a repo-wide sweep (dated artifact, intent-drift skipped). Config load is lenient — off-line, touches no tracker — so no new config key and no lib/ change (thin, ADR-0018). Does not touch the legacy cleanup workflow (step 11's scope). - commands/improve-architecture.md — the 7-step command - docs/adr/0027 + plugin ADR index row - AGENTS.md doctrine bullet; CHANGELOG [Unreleased] entry - plugin.json description adds improve-architecture - redesign progress table: step 10 done Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
/improve-architecture composes Matt Pocock's codebase-design, grilling, and domain-modeling skills by name, but they were never vendored into .agents/skills/ (absent from develop). Add them so the command's compositions resolve. This also backfills a latent gap for /triage, which already composes /grilling + /domain-modeling. improve-codebase-architecture was already committed, so it is untouched here. Scope is deliberately limited to these three needed skills — the broader skills-lock.json sync + other skill updates remain a separate concern. .agents/skills/ is prettier-ignored, so this is CI-neutral. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Restore the repo's lock+vendor pairing (every skill is both locked and vendored, per caveman/diagnose) for the codebase-design/grilling/domain-modeling dirs added for /improve-architecture. Entries are copied verbatim (source + path + computedHash) from the tool-generated worktree lock, so the later full skills sync merges cleanly (identical lines). Only these 3 entries are added; the rest of the pending sync stays uncommitted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes redesign step 10 for unic-archon-dlc by shipping /improve-architecture as a Claude Code command/skill (not an Archon workflow), and bumps the plugin to 0.9.0. It also adds the required Matt Pocock skill dependencies and documents the new ADR superseding/consolidation behavior.
Changes:
- Add the
/improve-architecturecommand/skill documentation and the supporting ADR (0027) describing intent drift, durable arch-review artifacts, and ADR superseding across both ADR homes. - Vendor additional Matt Pocock skills (
codebase-design,domain-modeling,grilling) and record them inskills-lock.json. - Version/documentation updates across
package.json, plugin manifests, changelog, and redesign tracking docs.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills-lock.json | Registers additional Matt Pocock skills required by the new command/skill composition. |
| apps/claude-code/unic-archon-dlc/package.json | Bumps plugin package version to 0.9.0. |
| apps/claude-code/unic-archon-dlc/docs/redesign/README.md | Marks step 10 as done and advances the redesign progress table. |
| apps/claude-code/unic-archon-dlc/docs/adr/README.md | Adds ADR index entry for 0027. |
| apps/claude-code/unic-archon-dlc/docs/adr/0027-improve-architecture-skill-superseding.md | New ADR defining the /improve-architecture box, modes, artifacts, and superseding mechanics. |
| apps/claude-code/unic-archon-dlc/commands/improve-architecture.md | New command/skill playbook describing config loading, delegation to Matt’s method, intent drift, artifact writing, and ADR gating/superseding. |
| apps/claude-code/unic-archon-dlc/CHANGELOG.md | Adds the 0.9.0 release entry describing /improve-architecture. |
| apps/claude-code/unic-archon-dlc/AGENTS.md | Adds /improve-architecture to the plugin’s load-bearing invariants. |
| apps/claude-code/unic-archon-dlc/.claude-plugin/plugin.json | Updates plugin metadata (version + description mentions improve-architecture). |
| apps/claude-code/unic-archon-dlc/.claude-plugin/marketplace.json | Updates marketplace version to 0.9.0. |
| .agents/skills/grilling/SKILL.md | Adds the grilling interactive interview skill dependency. |
| .agents/skills/domain-modeling/SKILL.md | Adds the domain-modeling skill dependency used for maintaining CONTEXT.md. |
| .agents/skills/domain-modeling/CONTEXT-FORMAT.md | Adds reference documentation for CONTEXT.md structure used by domain-modeling. |
| .agents/skills/domain-modeling/ADR-FORMAT.md | Adds ADR-writing guidance bundled with domain-modeling. |
| .agents/skills/codebase-design/SKILL.md | Adds architecture vocabulary skill dependency (codebase-design). |
| .agents/skills/codebase-design/DESIGN-IT-TWICE.md | Adds supporting technique doc for interface exploration used by codebase-design. |
| .agents/skills/codebase-design/DEEPENING.md | Adds supporting guidance for deepening/testing strategy used by codebase-design. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to Step 6 (Copilot review) Step 3 delegates to Matt's improve-codebase-architecture, which offers to write ADRs inline for load-bearing rejections. Make that offer capture-only: no ADR is written/numbered in Step 3, and the delegated skill must not write one either — proposed decisions are captured as candidates for the Step 6 gate. Step 6 is the single place ADRs are written, so the A/R/E gate, MADR-lite format, both-homes numbering, and superseding/index mechanics always apply (prevents format/process drift and gate bypass). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Redesign step 10 — ships
/improve-architecture, the off-line arch-health box, as a Claude Code command/skill (not an Archon workflow). Bumpsunic-archon-dlcto 0.9.0.Why
The shipped
unic-dlc-cleanupArchon workflow bundled two off-line concerns behind the inerttype:-style schema:arch-review(technical + intent drift, deepening) andadr-consolidation. The two-axis pivot (ADR-0017) splits arch-health out: because its core is a design grilling loop that needs the live conversation, it must be a command/skill — the same litmus that kept/triageand/specsinteractive.Rather than reimplement, it composes Matt Pocock's
improve-codebase-architectureverbatim (ADR-0021) — itsExplorewalk, deletion test, HTML deepening report, and/grillingloop — plus/codebase-design(architecture vocabulary) and/domain-modeling(keepCONTEXT.mdcurrent).What it adds over the raw skill (earns-its-place)
Matt's skill covers technical drift only, ephemerally. The DLC adds three layers:
arch-review.mdartifact under<artifacts_dir>/(ADR-0015).Grilled decisions (2026-07-03)
/improve-architecture <slug>(intent-grounded against a build session's PRD/report) ·/improve-architectureno-arg (repo-wide sweep, intent-drift skipped, dated artifact).Superseded by ADR-NNNN, matchingREADME.mdindex updated).<artifacts_dir>/arch-review-YYYY-MM-DD.md; per-slug →<artifacts_dir>/<slug>/arch-review.md.Changes
commands/improve-architecture.md— the 7-step command (lenient off-line config load; per-slug/sweep routing; delegate-to-Matt; intent-drift; durable artifact; per-ADR A/R/E superseding gate).docs/adr/0027-improve-architecture-skill-superseding.md+ plugin ADR index row.AGENTS.mddoctrine bullet;CHANGELOG.md[0.9.0];plugin.json/marketplace.jsondescription addsimprove-architecture; redesign progress table → step 10 done.lib/or config-schema change (thin, ADR-0018); no new tests (existing 109 stay green).unic-dlc-cleanup.yaml— that is/cleanup's (step 11) scope.Verification
typecheck✓ ·test109/109 ✓ ·verify:changelog→ 0.9.0 ✓ · biome + prettier clean on all 9 changed files.🤖 Generated with Claude Code