chore: rename core crate for release#92
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
|
|
||
| [workspace.dependencies] | ||
| agentic-core = { path = "crates/agentic-core" } | ||
| agentic-core = { package = "agentic-server-core", path = "crates/agentic-server-core", version = "0.1.0" } |
There was a problem hiding this comment.
The description says 0.0.1 (workspace version + this pin), but it's 0.1.0 here and the workspace version at line 6 is unchanged too — the diff doesn't bump anything. Which one's intended for the release? Worth pinning down since crates.io versions are immutable once published.
Minor while you're here: the packaged tarball still ships tests/ and benches/ sources but excludes their cassette fixtures, so cargo test from the published crate can't find them. Harmless for consumers, but excluding tests/** + benches/** too would slim it if you want.
There was a problem hiding this comment.
whoops this was a miss, fixed.
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
|
@franciscojavierarceo @ashwing let's merge the rename after #83? |
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Summary
agentic-coretoagentic-server-corewhile preserving the Rust library target nameagentic_core0.1.0and point the server dependency atagentic-server-core = 0.1.0agentic-praxisas unpublished and update docs references to the new core crate nameTest Plan
cargo fmt -- --checkcargo clippy --all-targets -- -D warningscargo testcargo publish --dry-run -p agentic-server-core --allow-dirtycargo package -p agentic-server-core --allow-dirty --listNote:
agentic-serverpackaging/publish dry-run cannot complete untilagentic-server-core v0.1.0exists in the crates.io index; Cargo fails dependency resolution withno matching package named agentic-server-core found, which is expected before publishing the core crate first.