Skip to content

chore: rename core crate for release#92

Merged
franciscojavierarceo merged 4 commits into
mainfrom
codex/rename-agentic-server-core
Jul 10, 2026
Merged

chore: rename core crate for release#92
franciscojavierarceo merged 4 commits into
mainfrom
codex/rename-agentic-server-core

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • rename the publishable core package from agentic-core to agentic-server-core while preserving the Rust library target name agentic_core
  • keep the workspace release version at 0.1.0 and point the server dependency at agentic-server-core = 0.1.0
  • mark agentic-praxis as unpublished and update docs references to the new core crate name
  • exclude local DB files, tests, and benches from the published core tarball

Test Plan

  • cargo fmt -- --check
  • cargo clippy --all-targets -- -D warnings
  • cargo test
  • cargo publish --dry-run -p agentic-server-core --allow-dirty
  • cargo package -p agentic-server-core --allow-dirty --list

Note: agentic-server packaging/publish dry-run cannot complete until agentic-server-core v0.1.0 exists in the crates.io index; Cargo fails dependency resolution with no matching package named agentic-server-core found, which is expected before publishing the core crate first.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

@ashwing ashwing left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the version before this goes out for a release, inline.

Comment thread Cargo.toml

[workspace.dependencies]
agentic-core = { path = "crates/agentic-core" }
agentic-core = { package = "agentic-server-core", path = "crates/agentic-server-core", version = "0.1.0" }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description says 0.0.1 (workspace version + this pin), but it's 0.1.0 here and the workspace version at line 6 is unchanged too — the diff doesn't bump anything. Which one's intended for the release? Worth pinning down since crates.io versions are immutable once published.

Minor while you're here: the packaged tarball still ships tests/ and benches/ sources but excludes their cassette fixtures, so cargo test from the published crate can't find them. Harmless for consumers, but excluding tests/** + benches/** too would slim it if you want.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops this was a miss, fixed.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

@maralbahari maralbahari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maralbahari

Copy link
Copy Markdown
Collaborator

@franciscojavierarceo @ashwing let's merge the rename after #83?
I added a comment for this. once addressed we can include this refactor with the release

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo merged commit a2e33e1 into main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants