GH-126 Make the DummyType regsitration work with doctrine/dbal:3|4#127
Open
func0der wants to merge 2 commits into
Open
GH-126 Make the DummyType regsitration work with doctrine/dbal:3|4#127func0der wants to merge 2 commits into
func0der wants to merge 2 commits into
Conversation
Contributor
Author
|
Unrelated changes from #128 inside here. Just to make the build green and the merge process easier, if you accept ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It solves the problem from GH-126 for doctrine/dbal 3 and 4.
Technically we change the API of the
DummyTypeclass, but it is not really part of the "public api" ofslimdump, why I would not say this is a BC.We could, if we wanted to be extra careful, introduce a second DummyType class which is only used for doctrine/dbal:^4
This is basically a bugfix for 1.17, since functionality was lost with allowance of doctrine/dbal:^4
AI disclosure: This code was created with the assitance of AI.