Add ML-KEM and ML-DSA support by aidangarske · Pull Request #399 · wolfSSL/wolfProvider

aidangarske · 2026-05-23T05:56:36Z

ML-KEM (FIPS 203) and ML-DSA (FIPS 204) via wolfSSL backend.

Algorithms: ML-KEM-512/768/1024, ML-DSA-44/65/87 hybrid schemes supported now as well

Opt-in: ./scripts/build-wolfprovider.sh --enable-pqc (adds --enable-mlkem --enable-mldsa to wolfSSL).

PQC is not auto detected its only enabled when specifically built.
Ability to enable either algo only or both
Reject pqc with debian bookworm build could test with trixie eventually
ML-DSA CertificateVerify signing and verification both work in TLS
wolfProvider now generates ML-DSA certs
wolfProvider X509 ML-DSA sigs are valid
osp integration with https://github.com/open-quantum-safe/oqs-demos/tree/main/nginx using ML-DSA and hybrid schemes and tested in CI

Validation: three independent paths cross-checked, all pass.

Internal unit tests (11 functions x 3 levels = 33 assertions) in make test
wolfProvider <-> OpenSSL 3.6+ default provider (12 cross-pairs)
wolfProvider <-> wolfSSL direct wc_* API (12 cross-pairs)
entire openssl mldsa mlkem test suite exercised in CI for full compatibility
Interop tests with hybrid in place as well

CI: new wolfssl-versions-pqc.yml runs three matrix rows - pre-PQC wolfSSL, latest stable, master -- and the three-way interop validator on the PQC-enabled rows.

Put floor to 3.6 where mldsa apis solid and 5.9.2 for pqc in general; added note that we could do lower than 3.6 if reuqested but offically support and test those higher versions

supplemental PR for interop test in wolfCrypt: wolfSSL/wolfssl#10603

Test plan

make test passes (all 11 PQC tests + existing suite)
./test/pqc_interop.test -- ALL PASS (24 cross-pairs)
Build against pre-PQC wolfSSL: PQC code paths skip, make test clean
CI green on all three matrix rows

Frauschi

Some smaller findings. The biggest "issue" imo is the usage of the now old ML-DSA API instead of the new one. But moving this to the new one should be easy.

Frauschi · 2026-05-27T11:45:49Z

Jenkins retest this please

aidangarske · 2026-05-30T00:16:08Z

Jenkins retest this please

Frauschi

LGTM

…A public only when actually decoded, give hybrid variant tables internal linkage

…on-zero length

… flakes

….9.2); fix wget TLS by setting LD_LIBRARY_PATH after nginx download

…rray of GIDs, so the loop ran once with a GID); drop install-layout-dependent mime.types include; add startup debug

…per wolfSSL ref), loading wolfProvider via provider.conf in non-replace builds

…op self push/PR trigger

…yields the public via ExportPubRaw)

…re private first since its encode embeds the public

…eed only for test-entropy/deterministic signing

… wc_MlDsaKey_SignCtxHash/VerifyCtxHash (pure path unchanged for md=NULL)

…eject the external-mu + pre-hash combination both ways

…x (do not assume the enum is zero)

…uard sigLen/key in the prehash sign path

…nd NULL-guard the prehash verify path

…_Shake256_Update) and SignMuWithSeed/VerifyMu, instead of buffering the whole message

… gate lost with SignMuWithSeed) and reject context/mu/encoding changes after streaming starts

…nal-mu input has been buffered, not just after pure streaming starts

Copilot AI review requested due to automatic review settings May 23, 2026 05:56

Copilot started reviewing on behalf of aidangarske May 23, 2026 05:56 View session

This comment was marked as resolved.

Sign in to view

aidangarske self-assigned this May 23, 2026

aidangarske marked this pull request as ready for review May 26, 2026 17:13

aidangarske requested review from ColtonWilley and Frauschi May 26, 2026 17:13

Frauschi requested changes May 27, 2026

View reviewed changes

aidangarske requested a review from Frauschi May 29, 2026 23:43

Frauschi previously approved these changes Jun 1, 2026

View reviewed changes

anhu reviewed Jun 4, 2026

View reviewed changes

Comment thread docs/INTEGRATION_GUIDE.md

Comment thread docs/INTEGRATION_GUIDE.md Outdated

Comment thread include/wolfprovider/settings.h Outdated

Comment thread src/wp_mlkem_kem.c

aidangarske dismissed Frauschi’s stale review via 65953c2 June 4, 2026 19:59

aidangarske requested a review from anhu June 4, 2026 20:00

padelsbach reviewed Jun 4, 2026

View reviewed changes

Comment thread src/wp_mldsa_kmgmt.c

Comment thread src/wp_mldsa_kmgmt.c

Comment thread src/wp_mlkem_kmgmt.c

Comment thread test/standalone/tests/pqc_interop/test_pqc_interop.c

aidangarske mentioned this pull request Jun 5, 2026

PQC enforce modulus and eta range checks in DecodePrivateKey wolfSSL/wolfssl#10603

Merged

aidangarske requested review from SparkiDev and removed request for ColtonWilley and anhu June 5, 2026 22:16

aidangarske assigned SparkiDev Jun 6, 2026

aidangarske force-pushed the pqc-support branch from 39fa5d2 to 6ccca9e Compare June 11, 2026 14:41

aidangarske added the ci:nginx-pqc PR OSP toggle: run nginx-pqc label Jun 11, 2026

SparkiDev requested changes Jun 16, 2026

View reviewed changes

Comment thread src/wp_mldsa_sig.c

Comment thread src/wp_mldsa_kmgmt.c Outdated

Comment thread src/wp_mlkem_kmgmt.c Outdated

Comment thread src/wp_mlkem_kmgmt.c Outdated

SparkiDev removed their assignment Jun 16, 2026

aidangarske requested review from ColtonWilley and SparkiDev June 16, 2026 17:41

aidangarske added ci:nginx-pqc PR OSP toggle: run nginx-pqc and removed ci:nginx-pqc PR OSP toggle: run nginx-pqc labels Jun 16, 2026

aidangarske added 18 commits June 25, 2026 13:41

PQC security review round 5: copy IKME on KEM dupctx, advertise ML-DS…

472676f

…A public only when actually decoded, give hybrid variant tables internal linkage

PQC security review round 6: reject NULL ML-DSA message update with n…

e5bce26

…on-zero length

nginx PQC test: lengthen HTTP response wait to avoid handshake-timing…

3c53164

… flakes

nginx PQC CI: skip pre-PQC-floor wolfSSL stable (master-only until v5…

e5666a6

….9.2); fix wget TLS by setting LD_LIBRARY_PATH after nginx download

nginx PQC test: rename GROUPS->KEX_GROUPS (GROUPS is a bash special a…

78dcf82

…rray of GIDs, so the loop ran once with a GID); drop install-layout-dependent mime.types include; add startup debug

nginx PQC: add replace-default/non-replace as a matrix axis (4 modes …

6e05cde

…per wolfSSL ref), loading wolfProvider via provider.conf in non-replace builds

ci: run nginx PQC OSP test nightly via reusable workflow (Wave 1), dr…

2b4fab7

…op self push/PR trigger

ML-DSA import: drop dead pub-probe (a FIPS 204 raw private key never …

cfe8bd4

…yields the public via ExportPubRaw)

ML-KEM import/match: set pub when priv is decoded (drop probe); compa…

b81fb5a

…re private first since its encode embeds the public

ML-DSA sign: let wolfSSL hedge the randomizer via SignCtx; supply a s…

f46e752

…eed only for test-entropy/deterministic signing

ML-DSA digest-sign: support FIPS 204 HashML-DSA via a digest object +…

de8fe5d

… wc_MlDsaKey_SignCtxHash/VerifyCtxHash (pure path unchanged for md=NULL)

ML-DSA pre-hash: allowlist SHA2/SHA3 digests (reject MD5/SHA-1) and r…

1366219

…eject the external-mu + pre-hash combination both ways

ML-DSA sig ctx: set hashType to WC_HASH_TYPE_NONE explicitly in newct…

88757a0

…x (do not assume the enum is zero)

ML-DSA pre-hash: allow SHA-512/256 in the digest allowlist and NULL-g…

1b9e302

…uard sigLen/key in the prehash sign path

ML-DSA pre-hash: set dup hashType only after a successful hash copy a…

2ec9547

…nd NULL-guard the prehash verify path

ML-DSA pure sign/verify: stream the message into mu via SHAKE-256 (wc…

f73e8e3

…_Shake256_Update) and SignMuWithSeed/VerifyMu, instead of buffering the whole message

ML-DSA streaming sign: reject public-only keys (restore the prvKeySet…

68aff0e

… gate lost with SignMuWithSeed) and reject context/mu/encoding changes after streaming starts

ML-DSA sig params: also reject context/mu/encoding changes once exter…

2880620

…nal-mu input has been buffered, not just after pure streaming starts

aidangarske force-pushed the pqc-support branch from 5d8f060 to 2880620 Compare June 25, 2026 20:44

aidangarske added ci:nginx-pqc PR OSP toggle: run nginx-pqc and removed ci:nginx-pqc PR OSP toggle: run nginx-pqc labels Jun 25, 2026

SparkiDev approved these changes Jun 29, 2026

View reviewed changes

SparkiDev assigned Frauschi, ColtonWilley and padelsbach and unassigned SparkiDev and aidangarske Jun 29, 2026

ColtonWilley approved these changes Jun 30, 2026

View reviewed changes

ColtonWilley merged commit 1d63d90 into wolfSSL:master Jun 30, 2026
125 checks passed

aidangarske deleted the pqc-support branch June 30, 2026 17:37

Uh oh!

Conversation

aidangarske commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

This comment was marked as resolved.

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi commented May 27, 2026

Uh oh!

aidangarske commented May 30, 2026

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aidangarske commented May 23, 2026 •

edited

Loading