Random: add DRBG reseed support#130
Open
mjdemilliano wants to merge 3 commits into
Open
Conversation
dgarske
reviewed
Jun 29, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: reviewOverall recommendation: COMMENT
Findings: 4 total — 4 posted, 0 skipped
4 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] test_reseed_empty asserts nothing and silently passes on either outcome —
tests/test_random.py:61-66 - [Low] Non-ASCII em-dash in test comment violates ASCII-only convention —
tests/test_random.py:66 - [Low] test_reseed only checks output length, not that reseed had any effect —
tests/test_random.py:55-58 - [Low] Per-method feature gate inside class body differs from repo's module-level gating pattern —
wolfcrypt/random.py:81-89
Review generated by Skoll
dgarske
reviewed
Jun 30, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-securityOverall recommendation: COMMENT
Findings: 3 total — 3 posted, 0 skipped
3 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] [review] reseed error branch missing # pragma: no cover used by every other error path —
wolfcrypt/random.py:88 - [Low] [review] Trailing whitespace on blank line inside test_reseed_multiple —
tests/test_random.py:79 - [Low] [review] Seed bytes use % 255, likely intended % 256 —
tests/test_random.py:61,77
Review generated by Skoll
- add pragma no cover - format using ruff - fix module factor in test_random
dgarske
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only available when Hash-DRBG is enabled, which is the default.