Prepare for v5.9.2 release#134
Open
mjdemilliano wants to merge 16 commits into
Open
Conversation
In the newer wolfSSL signing and verifying without context is not available unless it is explicitly enabled. This change modifies the Python binding and test suite to accommodate this.
Smaller authentication tags may not be supported by the library. This fix makes the test work for the default case that tags should be minimum 12 bytes in size.
Read minimum supported tag size from settings and make the test less ambiguous.
Also detect WOLFSSL_DILITHIUM_FIPS204_DRAFT as implying no-ctx support, mirroring the logic in dilithium.h. Add ML_DSA_NO_CTX to the default features dict for consistency with peer flags.
This place is more logical
- Test signing with empty context - Test deterministic signing with context
Test response by library explicitly when called with unsupported number of tag bytes.
sebastian-carpenter
previously approved these changes
Jun 30, 2026
sebastian-carpenter
left a comment
sebastian-carpenter
left a comment
Contributor
There was a problem hiding this comment.
One minor nitpick:
INFO-3: Typo "ML-DSDA" in comment [NIT] (style)
File: scripts/build_ffi.py:382
Function: get_features
Confidence: High
The comment reads "Determine if support for ML-DSDA signing & verification without context has been enabled." — "ML-DSDA" should be "ML-DSA".
Code:
# Determine if support for ML-DSDA signing & verification without context has been enabled.
Recommendation: Fix the typo.
Besides that the dilithium function signatures should be updated to the mldsa ones in the future. It looks like macro's reassign them right now so it shouldn't be blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.