0 memset kop in devcrypto_x25519 before use#10817
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses uninitialized-struct usage in the /dev/crypto-backed Curve25519 (X25519) implementation by zero-initializing the struct crypt_kop kop before populating its fields, matching the existing fix previously applied to the ECDSA devcrypto path.
Changes:
- Zero-initialize
crypt_kop(kop) inwc_DevCryptoCurve25519()prior to setting operation/session/params.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
0 memset kop in devcrypto_x25519 before use
This is the same change as in 5169875 but for devcrypto_x25519.c instead of devcrypto_ecdsa.c
Fixes F-4444
Testing
How did you test?
Checklist