chore: deploy internal p2p bootnodes first#24220
Merged
Merged
Conversation
PhilWindle
approved these changes
Jun 22, 2026
Contributor
Author
|
Needs a rebase on top of next after #24225 lands |
AztecBot
force-pushed
the
stack/chore-deploy-internal-p2p-bootnodes-first
branch
from
ffb1a53 to
881f225
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
1sgtpepper
pushed a commit
to 1sgtpepper/aztec-packages
that referenced
this pull request
Jun 26, 2026
) ## What Adds a Terraform `moved` block so the p2p bootstrap helm release refactor from AztecProtocol#24220 does not destroy and recreate the running bootstrap node. ```hcl moved { from = helm_release.releases["p2p_bootstrap"] to = helm_release.p2p_bootstrap[0] } ``` ## Why AztecProtocol#24220 ("deploy internal p2p bootnodes first") pulled `p2p_bootstrap` out of the `helm_releases` map — where it was instantiated via `helm_release.releases["p2p_bootstrap"]` — into its own `helm_release.p2p_bootstrap` resource (with `count`, addressed as `helm_release.p2p_bootstrap[0]`) so it could be applied before the rest of the releases. To Terraform those are two distinct resource addresses, so without a `moved` block a `terraform apply` against an existing network plans to destroy `helm_release.releases["p2p_bootstrap"]` and create `helm_release.p2p_bootstrap[0]`, tearing down and recreating the live bootstrap node. The `moved` block tells Terraform they are the same release, so it updates in place instead. The block is safe for networks deployed without an internal bootnode: when `DEPLOY_INTERNAL_BOOTNODE` is false the source address never existed in state and the `moved` is a no-op. ## Testing - `terraform fmt -check` passes. - `terraform init -backend=false` + `terraform validate` → `Success! The configuration is valid.` Refs AztecProtocol#24220 --- *Created by [claudebox](https://claudebox.work/v2/sessions/8fa6b13b3bb222a6) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.